Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 11472021: cc: Pass LayerTreeHostImpl to LayerImpl constructor (Closed)

Created:
8 years ago by enne (OOO)
Modified:
8 years ago
Reviewers:
danakj, jamesr
CC:
chromium-reviews, feature-media-reviews_chromium.org, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Pass LayerTreeHostImpl to LayerImpl constructor In order to allow for LayerImpl to notify its host when one of its property changes, it needs to more robustly have its host set (which is not the case in most tests). To avoid a recursive pass when adding children or after layer synchronization, instead just pass it to the constructor of LayerImpl, since a given LayerImpl will never move from one host to another. NOTRY=true BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171830

Patch Set 1 #

Total comments: 7

Patch Set 2 : Chromium style #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+954 lines, -652 lines) Patch
M cc/cc_tests.gyp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M cc/damage_tracker_unittest.cc View 14 chunks +112 lines, -101 lines 0 comments Download
M cc/delegated_renderer_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/delegated_renderer_layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/delegated_renderer_layer_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/delegated_renderer_layer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/delegated_renderer_layer_impl_unittest.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M cc/gl_renderer_unittest.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M cc/heads_up_display_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/heads_up_display_layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/heads_up_display_layer_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/heads_up_display_layer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/io_surface_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/io_surface_layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/io_surface_layer_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/io_surface_layer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layer.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M cc/layer.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layer_impl.h View 1 2 3 chunks +3 lines, -4 lines 0 comments Download
M cc/layer_impl.cc View 1 2 7 chunks +9 lines, -10 lines 0 comments Download
M cc/layer_impl_unittest.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M cc/layer_sorter_unittest.cc View 2 chunks +10 lines, -5 lines 0 comments Download
M cc/layer_tree_host_common_unittest.cc View 1 2 37 chunks +107 lines, -51 lines 0 comments Download
M cc/layer_tree_host_impl_unittest.cc View 59 chunks +138 lines, -142 lines 0 comments Download
M cc/layer_tree_host_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M cc/layer_unittest.cc View 4 chunks +15 lines, -3 lines 0 comments Download
M cc/nine_patch_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/nine_patch_layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/nine_patch_layer_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/nine_patch_layer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/nine_patch_layer_impl_unittest.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M cc/occlusion_tracker_unittest.cc View 14 chunks +35 lines, -13 lines 0 comments Download
M cc/picture_layer.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/picture_layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/picture_layer_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/picture_layer_impl.cc View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M cc/prioritized_resource_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/quad_culler_unittest.cc View 20 chunks +73 lines, -58 lines 0 comments Download
M cc/render_surface_unittest.cc View 5 chunks +14 lines, -6 lines 0 comments Download
M cc/scrollbar_animation_controller_linear_fade_unittest.cc View 2 chunks +13 lines, -3 lines 0 comments Download
M cc/scrollbar_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/scrollbar_layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/scrollbar_layer_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/scrollbar_layer_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M cc/scrollbar_layer_unittest.cc View 7 chunks +10 lines, -4 lines 0 comments Download
M cc/solid_color_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/solid_color_layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/solid_color_layer_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/solid_color_layer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/solid_color_layer_impl_unittest.cc View 7 chunks +16 lines, -5 lines 0 comments Download
A cc/test/fake_impl_proxy.h View 1 1 chunk +27 lines, -0 lines 0 comments Download
A cc/test/fake_layer_tree_host_impl.h View 1 1 chunk +26 lines, -0 lines 0 comments Download
A cc/test/fake_layer_tree_host_impl.cc View 1 1 chunk +20 lines, -0 lines 0 comments Download
A cc/test/fake_layer_tree_host_impl_client.h View 1 1 chunk +33 lines, -0 lines 0 comments Download
A + cc/test/fake_layer_tree_host_impl_client.cc View 1 chunk +5 lines, -9 lines 0 comments Download
M cc/test/tiled_layer_test_common.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/tiled_layer_test_common.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/texture_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/texture_layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/texture_layer_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/texture_layer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/texture_layer_unittest.cc View 4 chunks +7 lines, -3 lines 0 comments Download
M cc/tiled_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/tiled_layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/tiled_layer_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/tiled_layer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/tiled_layer_impl_unittest.cc View 4 chunks +95 lines, -73 lines 0 comments Download
M cc/tiled_layer_unittest.cc View 29 chunks +40 lines, -36 lines 0 comments Download
M cc/tree_synchronizer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/tree_synchronizer.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M cc/tree_synchronizer_unittest.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M cc/video_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/video_layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/video_layer_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/video_layer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
enne (OOO)
One shaved yak, as ordered.
8 years ago (2012-12-07 07:14:37 UTC) #1
jamesr
lgtm https://codereview.chromium.org/11472021/diff/1/cc/test/fake_impl_proxy.h File cc/test/fake_impl_proxy.h (right): https://codereview.chromium.org/11472021/diff/1/cc/test/fake_impl_proxy.h#newcode11 cc/test/fake_impl_proxy.h:11: namespace cc { can you put this in ...
8 years ago (2012-12-07 07:28:39 UTC) #2
enne (OOO)
https://codereview.chromium.org/11472021/diff/1/cc/test/fake_impl_proxy.h File cc/test/fake_impl_proxy.h (right): https://codereview.chromium.org/11472021/diff/1/cc/test/fake_impl_proxy.h#newcode11 cc/test/fake_impl_proxy.h:11: namespace cc { On 2012/12/07 07:28:40, jamesr wrote: > ...
8 years ago (2012-12-07 08:16:37 UTC) #3
nduca
holy yakshave batman
8 years ago (2012-12-07 17:51:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11472021/8076
8 years ago (2012-12-07 20:28:11 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-07 20:31:48 UTC) #6
Message was sent while issue was closed.
Change committed as 171830

Powered by Google App Engine
This is Rietveld 408576698