fixes #206, add checking for unary ops

fixes #206, add checking for unary ops
fixes #207, checking for boolean conversions

R=leafp@google.com, vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/9738d60ad922ac9a2fa7c4fca64d1a13a844d279

[Jennifer Messerly, 2015-06-04 00:14:43]

jmesserly@google.com changed reviewers:
+ leafp@google.com

[Jennifer Messerly, 2015-06-04 00:16:23]

https://codereview.chromium.org/1147143007/diff/20001/lib/runtime/dart/conver...
File lib/runtime/dart/convert.js (right):

https://codereview.chromium.org/1147143007/diff/20001/lib/runtime/dart/conver...
lib/runtime/dart/convert.js:1207: if (!dart.notNull(dart.as(dart.dload(object,
'isFinite'), core.bool)))
we'll probably want to do something about the nonNull as bool pattern of checks
...

[Jennifer Messerly, 2015-06-04 16:06:58]

jmesserly@google.com changed reviewers:
+ vsm@google.com
- leafp@google.com

[vsm, 2015-06-04 17:07:32]

Almost lgtm - we're still missing the null check.  Could add that in the codegen
where we already have notNull, but it'd be nice to pull that into the checker -
e.g., at checkBoolean here.  WDYT?

https://codereview.chromium.org/1147143007/diff/20001/lib/runtime/dart/_isola...
File lib/runtime/dart/_isolate_helper.js (right):

https://codereview.chromium.org/1147143007/diff/20001/lib/runtime/dart/_isola...
lib/runtime/dart/_isolate_helper.js:592: if
(dart.as(dart.dsend(this.doneHandlers, 'contains', responsePort), core.bool))
We'll need a null check here as well.

https://codereview.chromium.org/1147143007/diff/20001/lib/src/codegen/js_code...
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1147143007/diff/20001/lib/src/codegen/js_code...
lib/src/codegen/js_codegen.dart:2164: return new JS.If(_visit(node.condition),
_visit(node.thenStatement),
E.g., s/_visit(node.condition)/notNull(node.condition)/

or handle in checker?

[Jennifer Messerly, 2015-06-04 21:54:18]

PTAL, adds null checks to codegen now. Also improves isNonNullable so the
generated code is slightly less insane.

https://codereview.chromium.org/1147143007/diff/20001/lib/runtime/dart/_isola...
File lib/runtime/dart/_isolate_helper.js (right):

https://codereview.chromium.org/1147143007/diff/20001/lib/runtime/dart/_isola...
lib/runtime/dart/_isolate_helper.js:592: if
(dart.as(dart.dsend(this.doneHandlers, 'contains', responsePort), core.bool))
On 2015/06/04 17:07:32, vsm wrote:
> We'll need a null check here as well.

Done.

https://codereview.chromium.org/1147143007/diff/20001/lib/src/codegen/js_code...
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1147143007/diff/20001/lib/src/codegen/js_code...
lib/src/codegen/js_codegen.dart:2164: return new JS.If(_visit(node.condition),
_visit(node.thenStatement),
On 2015/06/04 17:07:32, vsm wrote:
> E.g., s/_visit(node.condition)/notNull(node.condition)/
> 
> or handle in checker?

Done.

[Jennifer Messerly, 2015-06-04 22:00:21]

Patchset #4 (id:60001) has been deleted

[Leaf, 2015-06-05 18:12:25]

leafp@google.com changed reviewers:
+ leafp@google.com

[Leaf, 2015-06-05 18:12:27]

lgtm

[vsm, 2015-06-05 19:11:23]

lgtm

[Jennifer Messerly, 2015-06-05 19:12:32]

Committed patchset #5 (id:100001) manually as
9738d60ad922ac9a2fa7c4fca64d1a13a844d279 (presubmit successful).