Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: lib/runtime/dart/math.js

Issue 1147143007: fixes #206, add checking for unary ops (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: merged Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/runtime/dart/core.js ('k') | lib/src/checker/checker.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart/math.js
diff --git a/lib/runtime/dart/math.js b/lib/runtime/dart/math.js
index 75011d864d0cf9eeabb265458c4d37a91672e4b0..0f5f2d7b2d8dd7eecee4f363c8d405458fabd324 100644
--- a/lib/runtime/dart/math.js
+++ b/lib/runtime/dart/math.js
@@ -42,7 +42,7 @@ var _js_helper = dart.lazyImport(_js_helper);
['=='](other) {
if (!dart.is(other, Point$()))
return false;
- return dart.notNull(dart.equals(this.x, dart.dload(other, 'x'))) && dart.notNull(dart.equals(this.y, dart.dload(other, 'y')));
+ return dart.equals(this.x, dart.dload(other, 'x')) && dart.equals(this.y, dart.dload(other, 'y'));
}
get hashCode() {
return _JenkinsSmiHash.hash2(dart.hashCode(this.x), dart.hashCode(this.y));
@@ -113,7 +113,7 @@ var _js_helper = dart.lazyImport(_js_helper);
['=='](other) {
if (!dart.is(other, Rectangle))
return false;
- return dart.notNull(dart.equals(this.left, dart.dload(other, 'left'))) && dart.notNull(dart.equals(this.top, dart.dload(other, 'top'))) && dart.notNull(dart.equals(this.right, dart.dload(other, 'right'))) && dart.notNull(dart.equals(this.bottom, dart.dload(other, 'bottom')));
+ return dart.equals(this.left, dart.dload(other, 'left')) && dart.equals(this.top, dart.dload(other, 'top')) && dart.equals(this.right, dart.dload(other, 'right')) && dart.equals(this.bottom, dart.dload(other, 'bottom'));
}
get hashCode() {
return _JenkinsSmiHash.hash4(dart.hashCode(this.left), dart.hashCode(this.top), dart.hashCode(this.right), dart.hashCode(this.bottom));
@@ -179,8 +179,8 @@ var _js_helper = dart.lazyImport(_js_helper);
Rectangle(left, top, width, height) {
this.left = left;
this.top = top;
- this.width = dart.as(width['<'](0) ? dart.notNull(width['unary-']()) * 0 : width, T);
- this.height = dart.as(height['<'](0) ? dart.notNull(height['unary-']()) * 0 : height, T);
+ this.width = dart.as(dart.notNull(width['<'](0)) ? dart.notNull(width['unary-']()) * 0 : width, T);
+ this.height = dart.as(dart.notNull(height['<'](0)) ? dart.notNull(height['unary-']()) * 0 : height, T);
super._RectangleBase();
}
static fromPoints(a, b) {
@@ -207,8 +207,8 @@ var _js_helper = dart.lazyImport(_js_helper);
MutableRectangle(left, top, width, height) {
this.left = left;
this.top = top;
- this[_width] = dart.as(width['<'](0) ? _clampToZero(width) : width, T);
- this[_height] = dart.as(height['<'](0) ? _clampToZero(height) : height, T);
+ this[_width] = dart.as(dart.notNull(width['<'](0)) ? _clampToZero(width) : width, T);
+ this[_height] = dart.as(dart.notNull(height['<'](0)) ? _clampToZero(height) : height, T);
super._RectangleBase();
}
static fromPoints(a, b) {
@@ -223,7 +223,7 @@ var _js_helper = dart.lazyImport(_js_helper);
}
set width(width) {
dart.as(width, T);
- if (width['<'](0))
+ if (dart.notNull(width['<'](0)))
width = dart.as(_clampToZero(width), T);
this[_width] = width;
}
@@ -232,7 +232,7 @@ var _js_helper = dart.lazyImport(_js_helper);
}
set height(height) {
dart.as(height, T);
- if (height['<'](0))
+ if (dart.notNull(height['<'](0)))
height = dart.as(_clampToZero(height), T);
this[_height] = height;
}
@@ -297,7 +297,7 @@ var _js_helper = dart.lazyImport(_js_helper);
return dart.notNull(a) + dart.notNull(b);
}
}
- if (b[dartx.isNaN])
+ if (dart.notNull(b[dartx.isNaN]))
return b;
return a;
}
« no previous file with comments | « lib/runtime/dart/core.js ('k') | lib/src/checker/checker.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698