Move DecodeFilenameValue and DecodeExt value into http_content_disposition.

Move DecodeFilenameValue and DecodeExt value into http_content_disposition.

BUG=none


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173307

[asanka, 2012-12-10 18:18:50]

PTAL? I moved these functions and added some comments. It seems cleaner to have
it in HttpContentDisposition before adding the UMA to measure
Content-Disposition header usage.

[asanka, 2012-12-11 17:08:43]

On 2012/12/10 18:18:50, asanka wrote:
> PTAL? I moved these functions and added some comments. It seems cleaner to
have
> it in HttpContentDisposition before adding the UMA to measure
> Content-Disposition header usage.

Ping?

[asanka, 2012-12-13 21:14:19]

On 2012/12/10 18:18:50, asanka wrote:
> PTAL? I moved these functions and added some comments. It seems cleaner to
have
> it in HttpContentDisposition before adding the UMA to measure
> Content-Disposition header usage.

rvargas: Would you mind taking a look? This is needed by
https://codereview.chromium.org/11478034/.

abarth is OOO.

[rvargas (doing something else), 2012-12-13 22:44:43]

LGTM

https://codereview.chromium.org/11471041/diff/1/net/http/http_content_disposi...
File net/http/http_content_disposition.cc (right):

https://codereview.chromium.org/11471041/diff/1/net/http/http_content_disposi...
net/http/http_content_disposition.cc:19: namespace {
nit: It looks like all this code is fairly independent of net::.  Do you mind
keeping this namespace outside of net?

[asanka, 2012-12-13 23:28:47]

Thanks!

https://codereview.chromium.org/11471041/diff/1/net/http/http_content_disposi...
File net/http/http_content_disposition.cc (right):

https://codereview.chromium.org/11471041/diff/1/net/http/http_content_disposi...
net/http/http_content_disposition.cc:19: namespace {
On 2012/12/13 22:44:43, rvargas wrote:
> nit: It looks like all this code is fairly independent of net::.  Do you mind
> keeping this namespace outside of net?

Done in patch set 3.

[commit-bot: I haz the power, 2012-12-14 17:01:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asanka@chromium.org/11471041/11001

[commit-bot: I haz the power, 2012-12-14 22:07:28]

Retried try job too often on win_rel for step(s) browser_tests

[commit-bot: I haz the power, 2012-12-15 16:28:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asanka@chromium.org/11471041/11001

[commit-bot: I haz the power, 2012-12-15 20:07:33]

Change committed as 173307