Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1572)

Unified Diff: net/base/net_util.h

Issue 11471041: Move DecodeFilenameValue and DecodeExt value into http_content_disposition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move non-net code out of net namespace. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/base/net_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/net_util.h
diff --git a/net/base/net_util.h b/net/base/net_util.h
index 444a547b8d21872e89e1683ecc4063424fef72a8..874f3e20308a27e165bdf7b3f2dc0ea60a86cf71 100644
--- a/net/base/net_util.h
+++ b/net/base/net_util.h
@@ -173,12 +173,6 @@ NET_EXPORT std::string GetHostOrSpecFromURL(const GURL& url);
NET_EXPORT std::string GetSpecificHeader(const std::string& headers,
const std::string& name);
-// TODO(abarth): Move these functions to http_content_disposition.cc.
-bool DecodeFilenameValue(const std::string& input,
- const std::string& referrer_charset,
- std::string* output);
-bool DecodeExtValue(const std::string& value, std::string* output);
-
// Converts the given host name to unicode characters. This can be called for
// any host name, if the input is not IDN or is invalid in some way, we'll just
// return the ASCII source so it is still usable.
@@ -252,9 +246,8 @@ NET_EXPORT string16 StripWWWFromHost(const GURL& url);
// Generates a filename using the first successful method from the following (in
// order):
//
-// 1) The raw Content-Disposition header in |content_disposition| (as read from
-// the network. |referrer_charset| is used as described in the comment for
-// GetFileNameFromCD().
+// 1) The raw Content-Disposition header in |content_disposition| as read from
+// the network. |referrer_charset| is used to decode non-ASCII strings.
// 2) |suggested_name| if specified. |suggested_name| is assumed to be in
// UTF-8.
// 3) The filename extracted from the |url|. |referrer_charset| will be used to
« no previous file with comments | « no previous file | net/base/net_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698