Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1147103002: [Android Log] Move Presubmit checks to upload time only (Closed)

Created:
5 years, 7 months ago by dgn
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android Log] Move Presubmit checks to upload time only They are intended to be FYI checks. If they are ignored at upload time, submitting should still work. BUG= Committed: https://crrev.com/bbbc31f51f395da43b5234155b1e75496035aaad Cr-Commit-Position: refs/heads/master@{#330922}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M PRESUBMIT.py View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
dgn
5 years, 7 months ago (2015-05-20 18:18:37 UTC) #2
newt (away)
lgtm thanks!
5 years, 7 months ago (2015-05-20 18:20:11 UTC) #3
dgn
jochen@, phajdan.jr: PTAL
5 years, 7 months ago (2015-05-20 20:25:57 UTC) #5
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-21 07:51:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147103002/1
5 years, 7 months ago (2015-05-21 09:42:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-21 09:53:27 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 09:54:26 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bbbc31f51f395da43b5234155b1e75496035aaad
Cr-Commit-Position: refs/heads/master@{#330922}

Powered by Google App Engine
This is Rietveld 408576698