PRESUBMIT.py - Issue 1147103002: [Android Log] Move Presubmit checks to upload time only

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 1147103002: [Android Log] Move Presubmit checks to upload time only (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 4548d4e461ab734c8fdeba9a94a3fb8b6a216b18..751ae525751be38445e4bca2fd0a02c0ac7dd03e 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -1497,7 +1497,6 @@ def _CommonChecks(input_api, output_api):

results.extend(_CheckForCopyrightedCode(input_api, output_api))

results.extend(_CheckForWindowsLineEndings(input_api, output_api))

results.extend(_CheckSingletonInHeaders(input_api, output_api))

- results.extend(_CheckNoNewUtilLogUsage(input_api, output_api))

if any('PRESUBMIT.py' == f.LocalPath() for f in input_api.AffectedFiles()):

results.extend(input_api.canned_checks.RunUnitTestsInDirectory(

@@ -1725,6 +1724,7 @@ def CheckChangeOnUpload(input_api, output_api):

results.extend(

input_api.canned_checks.CheckGNFormatted(input_api, output_api))

results.extend(_CheckUmaHistogramChanges(input_api, output_api))

+ results.extend(_CheckNoNewUtilLogUsage(input_api, output_api))

return results

« no previous file with comments | « no previous file | no next file » | no next file with comments »