Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1147093008: Revert of Make sure that tracing is always cleaned up for v8_gc_times page_test (Closed)

Created:
5 years, 7 months ago by samuong
Modified:
5 years, 7 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make sure that tracing is always cleaned up for v8_gc_times page_test (patchset #4 id:60001 of https://codereview.chromium.org/1151933005/) Reason for revert: I suspect this is causing failures on telemetry_perf_unittests - see https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29 build #37836 and later Original issue's description: > Make sure that tracing is always cleaned up for v8_gc_times page_test > > BUG=491104 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect > > Committed: https://crrev.com/1d1d10c687de9424db5a66a89d179f11784d7ee8 > Cr-Commit-Position: refs/heads/master@{#331590} TBR=sullivan@chromium.org,rmcilroy@chromium.org,prasadv@chromium.org,nednguyen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=491104 Committed: https://crrev.com/fb9823b0bd5819345dcb105740e765e34f2e09f8 Cr-Commit-Position: refs/heads/master@{#331669}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M tools/perf/measurements/v8_gc_times.py View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/perf/measurements/v8_gc_times_unittest.py View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/page_test_test_case.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
samuong
Created Revert of Make sure that tracing is always cleaned up for v8_gc_times page_test
5 years, 7 months ago (2015-05-27 22:10:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147093008/1
5 years, 7 months ago (2015-05-27 22:12:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-27 22:13:58 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 22:14:41 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb9823b0bd5819345dcb105740e765e34f2e09f8
Cr-Commit-Position: refs/heads/master@{#331669}

Powered by Google App Engine
This is Rietveld 408576698