tools/telemetry/telemetry/unittest_util/page_test_test_case.py - Issue 1147093008: Revert of Make sure that tracing is always cleaned up for v8_gc_times page_test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/unittest_util/page_test_test_case.py

Issue 1147093008: Revert of Make sure that tracing is always cleaned up for v8_gc_times page_test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/unittest_util/page_test_test_case.py

diff --git a/tools/telemetry/telemetry/unittest_util/page_test_test_case.py b/tools/telemetry/telemetry/unittest_util/page_test_test_case.py

index c838b08b63f8d656e88d69f1f04293efa12fb22f..5446b5129abcd5dc3fca22891f83e13b56bd9dc9 100644

--- a/tools/telemetry/telemetry/unittest_util/page_test_test_case.py

+++ b/tools/telemetry/telemetry/unittest_util/page_test_test_case.py

@@ -87,7 +87,7 @@

ActualStartTracing(*args, **kwargs)

start_tracing_called[0] = True

raise exceptions.IntentionalException

- browser.platform.tracing_controller.Start = FakeStartTracing

+ browser.StartTracing = FakeStartTracing

ActualStopTracing = browser.platform.tracing_controller.Stop

def FakeStopTracing(*args, **kwargs):

@@ -101,7 +101,7 @@

measurement = BuggyMeasurement()

try:

self.RunMeasurement(measurement, ps, options=options)

- except page_test.MultiTabTestAppCrashError:

+ except page_test.TestNotSupportedOnPlatformError:

pass

if start_tracing_called[0]:

self.assertTrue(stop_tracing_called[0])

« no previous file with comments | « tools/perf/measurements/v8_gc_times_unittest.py ('k') | no next file » | no next file with comments »