Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1147093002: Makes us compile mojo_view_manager_lib_unittests (Closed)

Created:
5 years, 7 months ago by sky
Modified:
5 years, 7 months ago
Reviewers:
msw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes us compile mojo_view_manager_lib_unittests We previously weren't. BUG=none TEST=none R=msw@chromium.org Committed: https://crrev.com/ddd3c8c5178cda359b8570d0e094a897aac1d168 Cr-Commit-Position: refs/heads/master@{#330792}

Patch Set 1 #

Patch Set 2 : And make it compile #

Patch Set 3 : cleanup #

Total comments: 2

Patch Set 4 : merge and feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -13 lines) Patch
M components/view_manager/BUILD.gn View 1 2 3 1 chunk +10 lines, -2 lines 0 comments Download
M components/view_manager/public/cpp/tests/BUILD.gn View 1 2 3 1 chunk +4 lines, -8 lines 0 comments Download
M components/view_manager/public/cpp/tests/run_all_unittests.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M mandoline/BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
sky
5 years, 7 months ago (2015-05-20 18:10:00 UTC) #1
msw
lgtm with a nit https://codereview.chromium.org/1147093002/diff/40001/components/view_manager/BUILD.gn File components/view_manager/BUILD.gn (right): https://codereview.chromium.org/1147093002/diff/40001/components/view_manager/BUILD.gn#newcode125 components/view_manager/BUILD.gn:125: ":apptests", nit: if you include ...
5 years, 7 months ago (2015-05-20 18:20:55 UTC) #2
sky
https://codereview.chromium.org/1147093002/diff/40001/components/view_manager/BUILD.gn File components/view_manager/BUILD.gn (right): https://codereview.chromium.org/1147093002/diff/40001/components/view_manager/BUILD.gn#newcode125 components/view_manager/BUILD.gn:125: ":apptests", On 2015/05/20 18:20:54, msw wrote: > nit: if ...
5 years, 7 months ago (2015-05-20 19:12:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147093002/60001
5 years, 7 months ago (2015-05-20 19:13:55 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-20 20:21:01 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 20:22:55 UTC) #8
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/ddd3c8c5178cda359b8570d0e094a897aac1d168
Cr-Commit-Position: refs/heads/master@{#330792}

Powered by Google App Engine
This is Rietveld 408576698