Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: components/view_manager/public/cpp/tests/BUILD.gn

Issue 1147093002: Makes us compile mojo_view_manager_lib_unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge and feedback Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/view_manager/BUILD.gn ('k') | components/view_manager/public/cpp/tests/run_all_unittests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/view_manager/public/cpp/tests/BUILD.gn
diff --git a/components/view_manager/public/cpp/tests/BUILD.gn b/components/view_manager/public/cpp/tests/BUILD.gn
index 9b61e4f68f738fd5e07aae4947701d29d6016f95..ea7238f7dfc0e8c90164e5558d1e4eed54d657f1 100644
--- a/components/view_manager/public/cpp/tests/BUILD.gn
+++ b/components/view_manager/public/cpp/tests/BUILD.gn
@@ -16,16 +16,12 @@ test("mojo_view_manager_lib_unittests") {
deps = [
"//base",
"//base/test:test_support",
-
- # TODO(vtl): These non-public deps are illegal here. This should be
- # converted to an apptest.
+ "//components/view_manager/public/cpp",
"//mojo/application/public/cpp",
- "//mojo/edk/system",
- "//mojo/public/cpp/system",
- "//mojo/services/geometry/public/cpp",
- "//mojo/services/geometry/public/interfaces",
- "//mojo/services/view_manager/public/cpp",
"//testing/gtest",
+ "//third_party/mojo/src/mojo/public/cpp/system",
+ "//third_party/mojo/src/mojo/edk/system",
+ "//ui/mojo/geometry:interfaces",
]
if (use_x11) {
« no previous file with comments | « components/view_manager/BUILD.gn ('k') | components/view_manager/public/cpp/tests/run_all_unittests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698