Promote deterministic build CI to real CI (tree closer, except for the Clang builder)

masters/master.chromium.fyi/master.cfg

Index: masters/master.chromium.fyi/master.cfg
diff --git a/masters/master.chromium.fyi/master.cfg b/masters/master.chromium.fyi/master.cfg
index 6dd2fdb8ee6ccc5c6bb0fa785c8828ced382ce1a..1908bb03c8adebe50efe548905508fbd8c003e94 100644
--- a/masters/master.chromium.fyi/master.cfg
+++ b/masters/master.chromium.fyi/master.cfg
@@ -100,6 +100,7 @@ s_chromium = Scheduler(
                   'CrWin7Goma(clbr)',  # not (clobber) cause crbug.com/399990
                   'CrWinClangGoma',
                   'CrWinClang',
+                  'CrWinClang Deterministic',
                   'CrWinClang(dbg)',
                   'CrWinClang(shared)',
                   'CrWinClang64',
@@ -1193,6 +1194,20 @@ b_chromium_win_clang_asan_shared_tester = {
   'auto_reboot': False,
 }
 
+b_chromium_win_clang_deterministic = {
+  'name': 'CrWinClang Deterministic',
+  # Work around an issue with NaCl build.

[Nico, 2015/06/04 21:45:33]

See all the "# not (clobber) cause crbug.com/399990" comments above; use a
shorter bot name instead

[Sébastien Marchand, 2015/06/05 18:44:42]

imho it's cleaner to change the slavebuilddir argument instead of trying to find
a bot name that's "short enough".

[Nico, 2015/06/05 18:46:44]

Maybe, but we should do the same everywhere. And I'm not sure if changing this
for the other bots will cause history loss.

[Sébastien Marchand, 2015/06/05 18:52:57]

In this case, what's the definition of a "short" name ? (i.e. is "CrWinClang
Deterministic" short enough, or should it be CrWinClangDet ?)

[Nico, 2015/06/05 18:58:43]

You have 18 characters. "ClangDeterministic" is 18, 'ClangWinRepeatable' is 18,
etc

[Sébastien Marchand, 2015/06/05 19:09:07]

ClangWinRepeatable it is.

+  'slavebuilddir': 'chr',
+  'factory': annotator_factory.AnnotatorFactory().BaseFactory(
+      'swarming/deterministic_build',
+      factory_properties = {
+        'configuration': 'Release',
+      }),
+  # Auto-reboot to try to clear up TEMP fill up issues.
+  'auto_reboot': True,
+  'category': 'clang tot',

[Nico, 2015/06/04 21:45:33]

You should use the bundled clang and go in the "win clang" category instead

[Sébastien Marchand, 2015/06/05 18:44:42]

Switched to "win clang", how can I make sure that I'm using the bundled clang ?
Is there a chromium/gclient recipe config flag that I should use or should it
just work ?

[Nico, 2015/06/05 18:46:44]

It should just work. The tot bots use the chromium_win_clang_tot config; as long
as you don't use that you're good.

[Sébastien Marchand, 2015/06/05 18:52:57]

It's what we're using, we'll see if it works.

[Nico, 2015/06/05 18:58:43]

https://codereview.chromium.org/1147043007/diff/80001/scripts/slave/recipes/s...
says `'chromium_config': 'chromium_win_clang',` (note no _tot suffix), so I
don't think you use the tot config. (Maybe I misunderstood what "It" referred
to)

[Sébastien Marchand, 2015/06/05 19:09:06]

Oh sorry, I missed the '_tot' suffix. Fixing this.

+}
+
 b_clang_tot_linux = {
   'name': 'ClangToTLinux',
   'factory': m_annotator.BaseFactory('chromium',
@@ -1987,6 +2002,7 @@ c['builders'] = [
   b_chromium_win_clang_asan_tester,
   b_chromium_win_clang_asan_shared,
   b_chromium_win_clang_asan_shared_tester,
+  b_chromium_win_clang_deterministic,
 
   # Control flow integrity.
   b_chromium_cfi_linux,