Promote deterministic build CI to real CI (tree closer, except for the Clang builder)

masters/master.chromium.fyi/master.cfg

 # vim: ft=python:
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from buildbot.changes.filter import ChangeFilter
 from buildbot.scheduler import Dependent
 from buildbot.scheduler import Nightly
 from buildbot.scheduler import Periodic
 from buildbot.scheduler import Scheduler
@@ skipping 82 matching lines @@
                   'Cr Win VS2013 (dbg)',
                   'Cr Win VS2013',
                   'CrWinGoma',
                   'CrWinGoma(dll)',  # not (shared) cause crbug.com/399990
                   'CrWin7Goma',
                   'CrWin7Goma(dll)',  # not (shared) cause crbug.com/399990
                   'CrWin7Goma(dbg)',
                   'CrWin7Goma(clbr)',  # not (clobber) cause crbug.com/399990
                   'CrWinClangGoma',
                   'CrWinClang',
+                  'CrWinClang Deterministic',
                   'CrWinClang(dbg)',
                   'CrWinClang(shared)',
                   'CrWinClang64',
                   'CrWinClang64(dbg)',
                   'CrWinClang64(dll)',  # not (shared) cause crbug.com/399990
                   'CrWinClangLLD',
                   'CrWinAsan',
                   'ClangToTLinux',
                   'ClangToTLinux (dbg)',
                   'ClangToTLinuxASan',
@@ skipping 1073 matching lines @@
   'category': 'clang tot',
   'auto_reboot': False,
 }
 b_chromium_win_clang_asan_shared_tester = {
   'name': 'CrWinAsan(dll) tester',
   'factory': m_annotator.BaseFactory('chromium'),
   'category': 'clang tot',
   'auto_reboot': False,
 }
 
+b_chromium_win_clang_deterministic = {
+  'name': 'CrWinClang Deterministic',
+  # Work around an issue with NaCl build.

[Nico, 2015/06/04 21:45:33]

See all the "# not (clobber) cause crbug.com/399990" comments above; use a
shorter bot name instead

[Sébastien Marchand, 2015/06/05 18:44:42]

imho it's cleaner to change the slavebuilddir argument instead of trying to find
a bot name that's "short enough".

[Nico, 2015/06/05 18:46:44]

Maybe, but we should do the same everywhere. And I'm not sure if changing this
for the other bots will cause history loss.

[Sébastien Marchand, 2015/06/05 18:52:57]

In this case, what's the definition of a "short" name ? (i.e. is "CrWinClang
Deterministic" short enough, or should it be CrWinClangDet ?)

[Nico, 2015/06/05 18:58:43]

You have 18 characters. "ClangDeterministic" is 18, 'ClangWinRepeatable' is 18,
etc

[Sébastien Marchand, 2015/06/05 19:09:07]

ClangWinRepeatable it is.

+  'slavebuilddir': 'chr',
+  'factory': annotator_factory.AnnotatorFactory().BaseFactory(
+      'swarming/deterministic_build',
+      factory_properties = {
+        'configuration': 'Release',
+      }),
+  # Auto-reboot to try to clear up TEMP fill up issues.
+  'auto_reboot': True,
+  'category': 'clang tot',

[Nico, 2015/06/04 21:45:33]

You should use the bundled clang and go in the "win clang" category instead

[Sébastien Marchand, 2015/06/05 18:44:42]

Switched to "win clang", how can I make sure that I'm using the bundled clang ?
Is there a chromium/gclient recipe config flag that I should use or should it
just work ?

[Nico, 2015/06/05 18:46:44]

It should just work. The tot bots use the chromium_win_clang_tot config; as long
as you don't use that you're good.

[Sébastien Marchand, 2015/06/05 18:52:57]

It's what we're using, we'll see if it works.

[Nico, 2015/06/05 18:58:43]

https://codereview.chromium.org/1147043007/diff/80001/scripts/slave/recipes/s...
says `'chromium_config': 'chromium_win_clang',` (note no _tot suffix), so I
don't think you use the tot config. (Maybe I misunderstood what "It" referred
to)

[Sébastien Marchand, 2015/06/05 19:09:06]

Oh sorry, I missed the '_tot' suffix. Fixing this.

+}
+
 b_clang_tot_linux = {
   'name': 'ClangToTLinux',
   'factory': m_annotator.BaseFactory('chromium',
                                      triggers=['clang_tot_linux']),
   'category': 'clang tot',
   'auto_reboot': False,
 }
 b_clang_tot_linux_tester = {
   'name': 'ClangToTLinux tester',
   'factory': m_annotator.BaseFactory('chromium'),
@@ skipping 774 matching lines @@
   b_clang_tot_win64_dbg,
   b_clang_tot_win64_dbg_tester,
   b_clang_tot_win64_dll,
   b_clang_tot_win64_dll_tester,
   b_chromium_win_clang_lld,
   b_chromium_win_clang_lld_tester,
   b_chromium_win_clang_asan,
   b_chromium_win_clang_asan_tester,
   b_chromium_win_clang_asan_shared,
   b_chromium_win_clang_asan_shared_tester,
+  b_chromium_win_clang_deterministic,
 
   # Control flow integrity.
   b_chromium_cfi_linux,
 ]
 
 # DrMemory test bots
 b_win_drmemory = [
   b_chromium_windows_drmemory_builder,
   b_chromium_rel_win_drmemory_xp,
   b_chromium_tests_drmemory,
@@ skipping 123 matching lines @@
 c['status'].append(MailNotifier(
       fromaddr=ActiveMaster.from_address,  # Reply-To address
       mode='failing',
       relayhost=config.Master.smtp,
       subject='Remoting Android Tests failing on %(builder)s',
       extraRecipients=[
         'remoting-android-test-results@google.com',
       ],
       sendToInterestedUsers=False,
       builders=['Android Remoting Tests']))