Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 1147003007: Revert of Use script in depot_tools to retrieve builders from new cq.cfg (Closed)

Created:
5 years, 6 months ago by Nico
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use script in depot_tools to retrieve builders from new cq.cfg (patchset #10 id:180001 of https://codereview.chromium.org/1152823005/) Reason for revert: Speculative, looks like this broke `git cl try` for me (crbug.com/495219) Original issue's description: > Use script in depot_tools to retrieve builders from new cq.cfg > > R=pgervais@chromium.org > TEST=ran git-cl-try on this CL > > Committed: https://crrev.com/87e80c7a628381644013e3b96b437276d9b19bcd > Cr-Commit-Position: refs/heads/master@{#332200} TBR=jochen@chromium.org,brettw@chromium.org,cpu@chromium.org,jam@chromium.org,pgervais@chromium.org,sergiyb@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/4090c5cf35c931faf6c165373a940ee05950ffa9 Cr-Commit-Position: refs/heads/master@{#332232}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -24 lines) Patch
M PRESUBMIT.py View 1 chunk +25 lines, -24 lines 0 comments Download
A testing/commit_queue/OWNERS View 1 chunk +7 lines, -0 lines 0 comments Download
A testing/commit_queue/config.json View 1 chunk +102 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
Created Revert of Use script in depot_tools to retrieve builders from new cq.cfg
5 years, 6 months ago (2015-06-01 19:08:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147003007/1
5 years, 6 months ago (2015-06-01 19:12:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-01 19:16:29 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4090c5cf35c931faf6c165373a940ee05950ffa9 Cr-Commit-Position: refs/heads/master@{#332232}
5 years, 6 months ago (2015-06-01 19:18:11 UTC) #4
pgervais
5 years, 4 months ago (2015-08-03 20:42:03 UTC) #5
Message was sent while issue was closed.
On 2015/06/01 19:18:11, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/4090c5cf35c931faf6c165373a940ee05950ffa9
> Cr-Commit-Position: refs/heads/master@{#332232}

lgtm (just to clear my list of TBR'd commits not acked)

Powered by Google App Engine
This is Rietveld 408576698