Issue 1146993003: Fix issue 23500

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1146993003: Fix issue 23500 (Closed)

Created:
5 years, 6 months ago by regis

Modified:
5 years, 6 months ago

Reviewers:
srdjan, hausner, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -40 lines)			Patch
M	runtime/vm/parser.h	View	1	2 chunks	+11 lines, -10 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	8 chunks	+39 lines, -25 lines	0 comments	Download
A +	tests/language/regress_23500_test.dart	View		1 chunk	+3 lines, -5 lines	0 comments	Download

Total messages: 6 (1 generated)

regis

See issue 23500 for a detailed explanation of the problem. Thanks, Regis

5 years, 6 months ago (2015-05-29 00:16:22 UTC) #2

regis

PTAL I renamed ParseFinallyBlock to EnsureFinallyClause, as discussed.

5 years, 6 months ago (2015-05-29 20:16:02 UTC) #3

regis

Committed patchset #2 (id:20001) manually as 601da25b9267cb83a52779ce3df081f64ecb3b1c (presubmit successful).

5 years, 6 months ago (2015-05-29 20:31:23 UTC) #5

Message was sent while issue was closed.

Thanks for fixing this!