Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: runtime/vm/parser.h

Issue 1146993003: Fix issue 23500 (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address review comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.h
diff --git a/runtime/vm/parser.h b/runtime/vm/parser.h
index 8233e0bb55251db0cc3e02051d121a8482ca52d2..a2492a69ef9d0d65c40d9e301f26dc8e8e244363 100644
--- a/runtime/vm/parser.h
+++ b/runtime/vm/parser.h
@@ -618,12 +618,13 @@ class Parser : public ValueObject {
LocalVariable* rethrow_stack_trace_var,
const GrowableObjectArray& handler_types,
bool* needs_stack_trace);
- // Parse finally block and create an AST for it.
- SequenceNode* ParseFinallyBlock(bool is_async,
- LocalVariable* exception_var,
- LocalVariable* stack_trace_var,
- LocalVariable* rethrow_exception_var,
- LocalVariable* rethrow_stack_trace_var);
+ // Parse or generate a finally clause.
+ SequenceNode* EnsureFinallyClause(bool parse,
+ bool is_async,
+ LocalVariable* exception_var,
+ LocalVariable* stack_trace_var,
+ LocalVariable* rethrow_exception_var,
+ LocalVariable* rethrow_stack_trace_var);
// Push try block onto the stack of try blocks in scope.
void PushTry(Block* try_block);
// Pop the inner most try block from the stack.
@@ -637,10 +638,10 @@ class Parser : public ValueObject {
// Add specified node to try block list so that it can be patched with
// inlined finally code if needed.
void AddNodeForFinallyInlining(AstNode* node);
- // Add the inlined finally block to the specified node.
- void AddFinallyBlockToNode(bool is_async,
- AstNode* node,
- InlinedFinallyNode* finally_node);
+ // Add the inlined finally clause to the specified node.
+ void AddFinallyClauseToNode(bool is_async,
+ AstNode* node,
+ InlinedFinallyNode* finally_clause);
AstNode* ParseTryStatement(String* label_name);
RawAbstractType* ParseConstFinalVarOrType(
ClassFinalizer::FinalizationKind finalization);
« no previous file with comments | « no previous file | runtime/vm/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698