Removing unused functions from WebSocketFrame class

Removing unused functions from WebSocketFrame class

This patch removes the following unused functions:
WebSocketFrame::makeFrameData()
WebSocketFrame::needsExtendedLengthField()
WebSocketFrame::appendFramePayload()
WebSocketFrame::parseFrame()
WebSocketFrame::isNonControlOpCode()
WebSocketFrame::isControlOpCode()
WebSocketFrame::isReservedOpCode()
WebSocketFrame::WebSocketFrame()

BUG=439559
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196289

[shiva.jm, 2015-06-01 11:56:16]

pls have a look.

[shiva.jm, 2015-06-01 11:58:14]

shiva.jm@samsung.com changed reviewers:
+ pdr@chromium.org

[shiva.jm, 2015-06-01 11:58:15]

pls have a look.

[pdr., 2015-06-01 22:10:40]

pdr@chromium.org changed reviewers:
+ tyoshino@chromium.org, yhirano@chromium.org

[pdr., 2015-06-01 22:10:40]

+cc tyoshino@chromium.org and yhirano@chromium.org who are listed as reviewers
in Source/modules/websockets/OWNERS and are more appropriate reviewers for this
code.

[yhirano, 2015-06-02 00:40:39]

On 2015/06/01 22:10:40, pdr wrote:
> +cc mailto:tyoshino@chromium.org and mailto:yhirano@chromium.org who are
listed as reviewers
> in Source/modules/websockets/OWNERS and are more appropriate reviewers for
this
> code.

Thanks for the cleanup. Can you delete ParseFrameResult and parseFrame as well?

[tyoshino (SeeGerritForStatus), 2015-06-02 03:48:23]

On 2015/06/02 00:40:39, yhirano wrote:
> On 2015/06/01 22:10:40, pdr wrote:
> > +cc mailto:tyoshino@chromium.org and mailto:yhirano@chromium.org who are
> listed as reviewers
> > in Source/modules/websockets/OWNERS and are more appropriate reviewers for
> this
> > code.
> 
> Thanks for the cleanup. Can you delete ParseFrameResult and parseFrame as
well?

And then, isNonControlOpCode, isControlOpCode, and isReservedOpCode, the
constructor with no argument, etc.

[shiva.jm, 2015-06-02 04:28:12]

pls have a look updated with comments.

[yhirano, 2015-06-02 04:46:18]

LGTM. Please update the issue description.

[shiva.jm, 2015-06-02 04:58:51]

The CQ bit was checked by shiva.jm@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-06-02 04:59:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1146943003/20001

[commit-bot: I haz the power, 2015-06-02 06:41:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-02 06:41:55]

Dry run: This issue passed the CQ dry run.

[shiva.jm, 2015-06-02 06:42:40]

The CQ bit was checked by shiva.jm@samsung.com

[shiva.jm, 2015-06-02 06:42:40]

The CQ bit was unchecked by shiva.jm@samsung.com

[shiva.jm, 2015-06-02 06:42:45]

The CQ bit was unchecked by shiva.jm@samsung.com

[shiva.jm, 2015-06-02 06:42:45]

The CQ bit was checked by shiva.jm@samsung.com

[commit-bot: I haz the power, 2015-06-02 06:43:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1146943003/20001

[commit-bot: I haz the power, 2015-06-02 06:48:19]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196289

[shiva.jm, 2015-06-03 04:56:43]

shiva.jm@samsung.com changed reviewers:
+ habib.virji@samsung.com