Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1172)

Unified Diff: Source/modules/websockets/WebSocketFrame.h

Issue 1146943003: Removing unused functions from WebSocketFrame class (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/modules/websockets/WebSocketFrame.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/websockets/WebSocketFrame.h
diff --git a/Source/modules/websockets/WebSocketFrame.h b/Source/modules/websockets/WebSocketFrame.h
index fdf136ba5d2dfdf413edcd081d9870f0b17b6602..7574281c71d0c23289b7f6db63a07c7e6128f22b 100644
--- a/Source/modules/websockets/WebSocketFrame.h
+++ b/Source/modules/websockets/WebSocketFrame.h
@@ -31,8 +31,6 @@
#ifndef WebSocketFrame_h
#define WebSocketFrame_h
-#include "wtf/text/WTFString.h"
-
namespace blink {
struct WebSocketFrame {
@@ -47,18 +45,6 @@ struct WebSocketFrame {
OpCodeInvalid = 0x10
};
- enum ParseFrameResult {
- FrameOK,
- FrameIncomplete,
- FrameError
- };
-
- static bool isNonControlOpCode(OpCode opCode) { return opCode == OpCodeContinuation || opCode == OpCodeText || opCode == OpCodeBinary; }
- static bool isControlOpCode(OpCode opCode) { return opCode == OpCodeClose || opCode == OpCodePing || opCode == OpCodePong; }
- static bool isReservedOpCode(OpCode opCode) { return !isNonControlOpCode(opCode) && !isControlOpCode(opCode); }
- static bool needsExtendedLengthField(size_t payloadLength);
- static ParseFrameResult parseFrame(char* data, size_t dataLength, WebSocketFrame&, const char*& frameEnd, String& errorString); // May modify part of data to unmask the frame.
-
// Flags for the constructor.
// This is not the bitmasks for frame composition / decomposition.
enum {
@@ -71,10 +57,8 @@ struct WebSocketFrame {
Masked = 16,
};
typedef unsigned Flags;
- WebSocketFrame();
// The Flags parameter shall be a combination of above flags.
WebSocketFrame(OpCode, const char* payload, size_t payloadLength, Flags = EmptyFlags);
- void makeFrameData(Vector<char>& frameData);
OpCode opCode;
bool final;
« no previous file with comments | « no previous file | Source/modules/websockets/WebSocketFrame.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698