content/browser/service_worker/service_worker_database_unittest.cc - Issue 1146913004: Service Worker: Add ServiceWorkerContainer.getRegistrations() method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_database_unittest.cc

Issue 1146913004: Service Worker: Add ServiceWorkerContainer.getRegistrations() method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make GetRegistrationsForOrigin() handle nullptr for resource param. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_database.h ('K') | « content/browser/service_worker/service_worker_database.cc ('k') | content/browser/service_worker/service_worker_dispatcher_host.h » ('j') | content/browser/service_worker/service_worker_storage.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_database_unittest.cc

diff --git a/content/browser/service_worker/service_worker_database_unittest.cc b/content/browser/service_worker/service_worker_database_unittest.cc

index e67a5ba916278e79dd2345577f59190bb06ab4f8..6767ee541f42265c098268b8ba70518e253c7ec4 100644

--- a/content/browser/service_worker/service_worker_database_unittest.cc

+++ b/content/browser/service_worker/service_worker_database_unittest.cc

@@ -391,8 +391,9 @@ TEST(ServiceWorkerDatabaseTest, GetRegistrationsForOrigin) {

GURL origin3("https://example.org");

std::vector<RegistrationData> registrations;

- EXPECT_EQ(ServiceWorkerDatabase::STATUS_OK,

- database->GetRegistrationsForOrigin(origin1, &registrations));

+ EXPECT_EQ(

+ ServiceWorkerDatabase::STATUS_OK,

+ database->GetRegistrationsForOrigin(origin1, &registrations, nullptr));

EXPECT_TRUE(registrations.empty());

std::vector<Resource> resources;

@@ -441,8 +442,9 @@ TEST(ServiceWorkerDatabaseTest, GetRegistrationsForOrigin) {

data4, resources, &deleted_version, &newly_purgeable_resources));

registrations.clear();

- EXPECT_EQ(ServiceWorkerDatabase::STATUS_OK,

- database->GetRegistrationsForOrigin(origin3, &registrations));

+ EXPECT_EQ(

+ ServiceWorkerDatabase::STATUS_OK,

+ database->GetRegistrationsForOrigin(origin3, &registrations, nullptr));

EXPECT_EQ(2U, registrations.size());

VerifyRegistrationData(data3, registrations[0]);

VerifyRegistrationData(data4, registrations[1]);

@@ -1433,8 +1435,9 @@ TEST(ServiceWorkerDatabaseTest, DeleteAllDataForOrigin) {

// The registrations for |origin1| should be removed.

std::vector<RegistrationData> registrations;

- EXPECT_EQ(ServiceWorkerDatabase::STATUS_OK,

- database->GetRegistrationsForOrigin(origin1, &registrations));

+ EXPECT_EQ(

+ ServiceWorkerDatabase::STATUS_OK,

+ database->GetRegistrationsForOrigin(origin1, &registrations, nullptr));

EXPECT_TRUE(registrations.empty());

GURL origin_out;

EXPECT_EQ(