content/browser/service_worker/service_worker_database.h - Issue 1146913004: Service Worker: Add ServiceWorkerContainer.getRegistrations() method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_database.h

Issue 1146913004: Service Worker: Add ServiceWorkerContainer.getRegistrations() method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make GetRegistrationsForOrigin() handle nullptr for resource param. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_context_wrapper.cc ('k') | content/browser/service_worker/service_worker_database.cc » ('j') | content/browser/service_worker/service_worker_storage.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_database.h

diff --git a/content/browser/service_worker/service_worker_database.h b/content/browser/service_worker/service_worker_database.h

index 13c0ed480a2623772118475ea4c07264a302d825..e875cdad13ff119e5cfd56058cf32350ae97a112 100644

--- a/content/browser/service_worker/service_worker_database.h

+++ b/content/browser/service_worker/service_worker_database.h

@@ -101,7 +101,8 @@ class CONTENT_EXPORT ServiceWorkerDatabase {

// successfully read or not found. Otherwise, returns an error.

Status GetRegistrationsForOrigin(

const GURL& origin,

- std::vector<RegistrationData>* registrations);

+ std::vector<RegistrationData>* registrations,

+ std::vector<std::vector<ResourceRecord>>* resource_lists);

michaeln 2015/06/05 21:50:41 since this param may be null, please name it |opt_

jungkees 2015/06/06 13:55:11 Renamed it |opt_resources_list|. Note that I found

// Reads all registrations from the database. Returns OK if successfully read

// or not found. Otherwise, returns an error.