Issue 114683002: Merge the QUIC unacked packet map with the unacked fec packet map and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 114683002: Merge the QUIC unacked packet map with the unacked fec packet map and (Closed)

Created:
7 years ago by ramant (doing other things)

Modified:
7 years ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Merge the QUIC unacked packet map with the unacked fec packet map and merge the retransmission timer with the discard fec timer. Merge internal change: 57978547 R=rch@chromium.org

Patch Set 1 : One more try #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+188 lines, -274 lines)			Patch
M	net/quic/quic_connection.h	View	3 chunks	+3 lines, -10 lines	0 comments	Download
M	net/quic/quic_connection.cc	View	10 chunks	+15 lines, -55 lines	0 comments	Download
M	net/quic/quic_connection_test.cc	View	3 chunks	+52 lines, -10 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager.h	View	7 chunks	+15 lines, -38 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager.cc	View	9 chunks	+23 lines, -85 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager_test.cc	View	24 chunks	+66 lines, -70 lines	0 comments	Download
M	net/quic/test_tools/quic_connection_peer.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/quic/test_tools/quic_connection_peer.cc	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	net/quic/test_tools/quic_sent_packet_manager_peer.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/quic/test_tools/quic_sent_packet_manager_peer.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

Was getting lot of server errors. Sorry for sending so much mail. Was able to ...

7 years ago (2013-12-12 22:45:30 UTC) #1

lgtm

Expand Messages | Collapse Messages