Merge the QUIC unacked packet map with the unacked fec packet map and

net/quic/quic_sent_packet_manager.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_QUIC_QUIC_SENT_PACKET_MANAGER_H_
 #define NET_QUIC_QUIC_SENT_PACKET_MANAGER_H_
 
 #include <deque>
 #include <list>
 #include <map>
@@ skipping 61 matching lines @@
                         const QuicClock* clock,
                         CongestionFeedbackType congestion_type);
   virtual ~QuicSentPacketManager();
 
   virtual void SetFromConfig(const QuicConfig& config);
 
   virtual void SetMaxPacketSize(QuicByteCount max_packet_size);
 
   // Called when a new packet is serialized.  If the packet contains
   // retransmittable data, it will be added to the unacked packet map.
-  void OnSerializedPacket(const SerializedPacket& serialized_packet,
-                          QuicTime serialized_time);
+  void OnSerializedPacket(const SerializedPacket& serialized_packet);
 
   // Called when a packet is retransmitted with a new sequence number.
   // Replaces the old entry in the unacked packet map with the new
   // sequence number.
   void OnRetransmittedPacket(QuicPacketSequenceNumber old_sequence_number,
                              QuicPacketSequenceNumber new_sequence_number);
 
   // Processes the incoming ack and returns true if the retransmission or ack
   // alarm should be reset.
   bool OnIncomingAck(const ReceivedPacketInfo& received_info,
                      QuicTime ack_receive_time);
 
   // Discards any information for the packet corresponding to |sequence_number|.
   // If this packet has been retransmitted, information on those packets
   // will be discarded as well.
   void DiscardUnackedPacket(QuicPacketSequenceNumber sequence_number);
 
-  // Discards all information about fec packet |sequence_number|.
-  void DiscardFecPacket(QuicPacketSequenceNumber sequence_number);
-
   // Returns true if the non-FEC packet |sequence_number| is unacked.
   bool IsUnacked(QuicPacketSequenceNumber sequence_number) const;
 
   // Requests retransmission of all unacked packets of |retransmission_type|.
   void RetransmitUnackedPackets(RetransmissionType retransmission_type);
 
   // Returns true if the unacked packet |sequence_number| has retransmittable
   // frames.  This will only return false if the packet has been acked, if a
   // previous transmission of this packet was ACK'd, or if this packet has been
   // retransmitted as with different sequence number.
   bool HasRetransmittableFrames(QuicPacketSequenceNumber sequence_number) const;
 
   // Returns true if there are pending retransmissions.
   bool HasPendingRetransmissions() const;
 
   // Retrieves the next pending retransmission.
   PendingRetransmission NextPendingRetransmission();
 
-  // Returns the time the fec packet was sent.
-  QuicTime GetFecSentTime(QuicPacketSequenceNumber sequence_number) const;
-
-  // Returns true if there are any unacked packets.
   bool HasUnackedPackets() const;
 
   // Returns the number of unacked packets which have retransmittable frames.
   size_t GetNumRetransmittablePackets() const;
 
-  // Returns true if there are any unacked FEC packets.
-  bool HasUnackedFecPackets() const;
-
   // Returns the smallest sequence number of a sent packet which has not been
   // acked by the peer.  Excludes any packets which have been retransmitted
   // with a new sequence number. If all packets have been acked, returns the
   // sequence number of the next packet that will be sent.
   QuicPacketSequenceNumber GetLeastUnackedSentPacket() const;
 
-  // Returns the smallest sequence number of a sent fec packet which has not
-  // been acked by the peer.  If all packets have been acked, returns the
-  // sequence number of the next packet that will be sent.
-  QuicPacketSequenceNumber GetLeastUnackedFecPacket() const;
-
   // Returns the set of sequence numbers of all unacked packets.
+  // Test only.
   SequenceNumberSet GetUnackedPackets() const;
 
   // Returns true if |sequence_number| is a previous transmission of packet.
   bool IsPreviousTransmission(QuicPacketSequenceNumber sequence_number) const;
 
   // TODO(ianswett): Combine the congestion control related methods below with
   // some of the methods above and cleanup the resulting code.
   // Called when we have received an ack frame from peer.
   // Returns a set containing all the sequence numbers to be nack retransmitted
   // as a result of the ack.
@@ skipping 10 matching lines @@
   // the number of bytes sent and if they were retransmitted.
   virtual void OnPacketSent(QuicPacketSequenceNumber sequence_number,
                             QuicTime sent_time,
                             QuicByteCount bytes,
                             TransmissionType transmission_type,
                             HasRetransmittableData has_retransmittable_data);
 
   // Called when the retransmission timer expires.
   virtual void OnRetransmissionTimeout();
 
-  // Called when the fec timout timer expires.  Returns the next timeout of the
-  // FEC timer if it should be reset, and QuicTime::Zero() otherwise.
-  virtual QuicTime OnAbandonFecTimeout();
-
   // Called when a packet is timed out, such as an RTO.  Removes the bytes from
   // the congestion manager, but does not change the congestion window size.
   virtual void OnPacketAbandoned(QuicPacketSequenceNumber sequence_number);
 
   // Calculate the time until we can send the next packet to the wire.
   // Note 1: When kUnknownWaitTime is returned, there is no need to poll
   // TimeUntilSend again until we receive an OnIncomingAckFrame event.
   // Note 2: Send algorithms may or may not use |retransmit| in their
   // calculations.
   virtual QuicTime::Delta TimeUntilSend(QuicTime now,
@@ skipping 23 matching lines @@
   void MaybeEnablePacing();
 
   bool using_pacing() const { return using_pacing_; }
 
 
  private:
   friend class test::QuicConnectionPeer;
   friend class test::QuicSentPacketManagerPeer;
 
   struct TransmissionInfo {
-    TransmissionInfo() {}
+    TransmissionInfo()
+        : retransmittable_frames(NULL),
+          sequence_number_length(PACKET_1BYTE_SEQUENCE_NUMBER),
+          sent_time(QuicTime::Zero()) { }
     TransmissionInfo(RetransmittableFrames* retransmittable_frames,
                      QuicSequenceNumberLength sequence_number_length)
         : retransmittable_frames(retransmittable_frames),
-          sequence_number_length(sequence_number_length) {
+          sequence_number_length(sequence_number_length),
+          sent_time(QuicTime::Zero()) {
     }
 
     RetransmittableFrames* retransmittable_frames;
     QuicSequenceNumberLength sequence_number_length;
+    // Zero when the packet is serialized, non-zero once it's sent.
+    QuicTime sent_time;
   };
 
   typedef linked_hash_map<QuicPacketSequenceNumber,
                           TransmissionInfo> UnackedPacketMap;
   typedef linked_hash_map<QuicPacketSequenceNumber,
-                          QuicTime> UnackedFecPacketMap;
-  typedef linked_hash_map<QuicPacketSequenceNumber,
                           TransmissionType> PendingRetransmissionMap;
   typedef base::hash_map<QuicPacketSequenceNumber, SequenceNumberSet*>
                          PreviousTransmissionMap;
 
   // Process the incoming ack looking for newly ack'd data packets.
   void HandleAckForSentPackets(const ReceivedPacketInfo& received_info);
 
-  // Process the incoming ack looking for newly ack'd FEC packets.
-  void HandleAckForSentFecPackets(const ReceivedPacketInfo& received_info);
-
   // Update the RTT if the ack is for the largest acked sequence number.
   void MaybeUpdateRTT(const ReceivedPacketInfo& received_info,
                       const QuicTime& ack_receive_time);
 
   // Marks |sequence_number| as having been seen by the peer.  Returns an
   // iterator to the next remaining unacked packet.
   UnackedPacketMap::iterator MarkPacketReceivedByPeer(
       QuicPacketSequenceNumber sequence_number);
 
   // Simply removes the entries, if any, from the unacked packet map
@@ skipping 15 matching lines @@
   // most recently transmitted as.
   QuicPacketSequenceNumber GetMostRecentTransmission(
       QuicPacketSequenceNumber sequence_number) const;
 
   // Clears up to |num_to_clear| previous transmissions in order to make room
   // in the ack frame for new acks.
   void ClearPreviousRetransmissions(size_t num_to_clear);
 
   void CleanupPacketHistory();
 
-  // When new packets are created which may be retransmitted, they are added
-  // to this map, which contains owning pointers to the contained frames.  If
-  // a packet is retransmitted, this map will contain entries for both the old
-  // and the new packet.  The old packet's retransmittable frames entry will be
-  // NULL, while the new packet's entry will contain the frames to retransmit.
+  // Newly serialized retransmittable and fec packets are added to this map,
+  // which contains owning pointers to any contained frames.  If a packet is
+  // retransmitted, this map will contain entries for both the old and the new
+  // packet. The old packet's retransmittable frames entry will be NULL, while
+  // the new packet's entry will contain the frames to retransmit.
   // If the old packet is acked before the new packet, then the old entry will
   // be removed from the map and the new entry's retransmittable frames will be
   // set to NULL.
   UnackedPacketMap unacked_packets_;
 
-  // Pending fec packets that have not been acked yet. These packets need to be
-  // cleared out of the cgst_window after a timeout since FEC packets are never
-  // retransmitted.
-  UnackedFecPacketMap unacked_fec_packets_;
-
   // Pending retransmissions which have not been packetized and sent yet.
   PendingRetransmissionMap pending_retransmissions_;
 
   // Map from sequence number to set of all sequence number that this packet has
   // been transmitted as.  If a packet has not been retransmitted, it will not
   // have an entry in this map.  If any transmission of a packet has been acked
   // it will not have an entry in this map.
   PreviousTransmissionMap previous_transmissions_map_;
 
   // Tracks if the connection was created by the server.
@@ skipping 17 matching lines @@
   // Number of times the RTO timer has fired in a row without receiving an ack.
   size_t consecutive_rto_count_;
   bool using_pacing_;
 
   DISALLOW_COPY_AND_ASSIGN(QuicSentPacketManager);
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_QUIC_SENT_PACKET_MANAGER_H_