 Chromium Code Reviews
 Chromium Code Reviews Issue 1146813010:
  Introduce moderate binding  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1146813010:
  Introduce moderate binding  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/android/java/src/org/chromium/chrome/browser/Tab.java | 
| diff --git a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java | 
| index 279e5e24bd9383a1cdcfc87d6a25544eb07eab4d..273a57012e8f9480c329d6da81299def0a09f1f7 100644 | 
| --- a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java | 
| +++ b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java | 
| @@ -565,6 +565,11 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener, | 
| // The tab crashed in background or was killed by the OS out-of-memory killer. | 
| //setNeedsReload(true); | 
| mNeedsReload = true; | 
| + if (!(activityState == ActivityState.PAUSED | 
| 
Yaron
2015/06/11 16:54:34
Can you pull this condition out to helper fn. (als
 
Jaekyun Seok (inactive)
2015/06/12 06:50:19
I realized that I should have checked the applicat
 | 
| + || activityState == ActivityState.STOPPED | 
| + || activityState == ActivityState.DESTROYED)) { | 
| + UmaSessionStats.logBackgroundRendererCrashOnForegroundApp(); | 
| 
Yaron
2015/06/11 16:54:34
Please just use RecordUserAction directly.
 
Jaekyun Seok (inactive)
2015/06/12 06:50:19
Done.
 | 
| + } | 
| } else { | 
| showSadTab(); | 
| UmaSessionStats.logRendererCrash(mWindowAndroid.getActivity().get()); |