chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeTabbedActivity.java - Issue 1146813010: Introduce moderate binding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 1146813010: Introduce moderate binding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add "Tab.TotalTabCountBeforeLeavingApp" histogram Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/Tab.java ('K') | « chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeMobileApplication.java ('k') | chrome/android/java_staging/src/org/chromium/chrome/browser/DeferredStartupHandler.java » ('j') | chrome/android/java_staging/src/org/chromium/chrome/browser/DeferredStartupHandler.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

diff --git a/chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

index c1918d3aa8090960a8620fbfbe8df8380d44f2f9..92343e246e63c228f50273572f3c57977443b11f 100644

--- a/chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

+++ b/chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

@@ -305,6 +305,8 @@ public class ChromeTabbedActivity extends CompositorChromeActivity implements Ac

@Override

public void onStopWithNative() {

super.onStopWithNative();

+ RecordHistogram.recordCountHistogram(

Yaron 2015/06/11 16:54:34 Why not handle both codepaths in application?

Jaekyun Seok (inactive) 2015/06/12 06:50:19 Because accessing ChromeTabbedActivity in ChromeMo

+ "Tab.TotalTabCountBeforeLeavingApp", mTabModelSelectorImpl.getTotalTabCount());

mTabModelSelectorImpl.saveState();

try {

getConnectionChangeReceiver().unregisterReceiver(ChromeTabbedActivity.this);