Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1146713002: Disable WebViewTest.ClearDataCache on Windows as it's flakily failing. (Closed)

Created:
5 years, 7 months ago by lazyboy
Modified:
5 years, 7 months ago
Reviewers:
Nico, brucedawson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable WebViewTest.ClearDataCache on Windows as it's flakily failing. BUG=489088 Test=None, internal change. Committed: https://crrev.com/cd48f4c5b99083ab5dc4442ef2f5fe49e79b0bdb Cr-Commit-Position: refs/heads/master@{#330454}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 13 (3 generated)
lazyboy
5 years, 7 months ago (2015-05-18 22:14:29 UTC) #2
brucedawson
lgtm
5 years, 7 months ago (2015-05-18 22:43:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146713002/1
5 years, 7 months ago (2015-05-18 23:10:30 UTC) #5
Nico
Since the test is new, can we revert the whole CL that added the test ...
5 years, 7 months ago (2015-05-18 23:12:11 UTC) #7
brucedawson
That would disable it for all platforms and it seems to be working reliably on ...
5 years, 7 months ago (2015-05-18 23:14:02 UTC) #8
lazyboy
On 2015/05/18 23:14:02, brucedawson wrote: > That would disable it for all platforms and it ...
5 years, 7 months ago (2015-05-18 23:25:44 UTC) #9
Nico
On 2015/05/18 23:25:44, lazyboy wrote: > On 2015/05/18 23:14:02, brucedawson wrote: > > That would ...
5 years, 7 months ago (2015-05-18 23:39:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 00:06:34 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cd48f4c5b99083ab5dc4442ef2f5fe49e79b0bdb Cr-Commit-Position: refs/heads/master@{#330454}
5 years, 7 months ago (2015-05-19 00:07:24 UTC) #12
lazyboy
5 years, 7 months ago (2015-05-19 00:34:58 UTC) #13
Message was sent while issue was closed.
On 2015/05/18 23:39:47, Nico wrote:
> On 2015/05/18 23:25:44, lazyboy wrote:
> > On 2015/05/18 23:14:02, brucedawson wrote:
> > > That would disable it for all platforms and it seems to be working
reliably
> on
> > > other platforms, I think?
> > 
> > IIUC, the test is failing on windows because of some EmbeddedTestServer
> > issues, responses are being cached where it shouldn't be cached.
> 
> In general, new code shouldn't add flakiness anywhere. Don't all other tests
> work with EmbeddedTestServer? Can the server be fixed?

It's not an issue with EmbeddedTestServer by itself only, it is related to
mocking server's response with cache-control header (that's my guess):
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/app...

Powered by Google App Engine
This is Rietveld 408576698