Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Unified Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 1146713002: Disable WebViewTest.ClearDataCache on Windows as it's flakily failing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/guest_view/web_view_browsertest.cc
diff --git a/chrome/browser/apps/guest_view/web_view_browsertest.cc b/chrome/browser/apps/guest_view/web_view_browsertest.cc
index 39203974b6caf49c2fdfa5ac8601460d4813de67..27f24f6b5a83ace972b9cb47b963d014745424ff 100644
--- a/chrome/browser/apps/guest_view/web_view_browsertest.cc
+++ b/chrome/browser/apps/guest_view/web_view_browsertest.cc
@@ -2349,7 +2349,14 @@ IN_PROC_BROWSER_TEST_F(WebViewTest, ClearData) {
<< message_;
}
-IN_PROC_BROWSER_TEST_F(WebViewTest, ClearDataCache) {
+#if defined(OS_WIN)
+// Test is disabled on Windows because it fails often (~9% time)
+// http://crbug.com/489088
+#define MAYBE_ClearDataCache DISABLED_ClearDataCache
+#else
+#define MAYBE_ClearDataCache ClearDataCache
+#endif
+IN_PROC_BROWSER_TEST_F(WebViewTest, MAYBE_ClearDataCache) {
TestHelper("testClearCache", "web_view/clear_data_cache", NEEDS_TEST_SERVER);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698