[Extensions] Move remaining notifications out of ExtensionSettingsHandler

extensions/browser/warning_service.h

Index: extensions/browser/warning_service.h
diff --git a/extensions/browser/warning_service.h b/extensions/browser/warning_service.h
index 5aa9a50a885898da5650caa9bafb849e9f42ba5d..c9ce73f3926d07dcb1c54ba8e5affa9f6783a755 100644
--- a/extensions/browser/warning_service.h
+++ b/extensions/browser/warning_service.h
@@ -38,7 +38,8 @@ class WarningService : public KeyedService,
  public:
   class Observer {
    public:
-    virtual void ExtensionWarningsChanged() = 0;
+    virtual void ExtensionWarningsChanged(
+        const std::set<std::string>& affected_extensions) = 0;

[not at google - send to devlin, 2015/05/19 20:35:05]

I'd like to pass around an ExtensionSet, but I see we're pigeonholed here by the
way the warning service is factored. Not worth the changes required to use real
Extensions rather than their IDs. In lieu of that, we can pass around an
ExtensionIdSet?

[Devlin, 2015/05/19 22:01:08]

Sure, why not.

   };
 
   // |browser_context| may be NULL for testing. In this case, be sure to not
@@ -75,7 +76,7 @@ class WarningService : public KeyedService,
   void RemoveObserver(Observer* observer);
 
  private:
-  void NotifyWarningsChanged();
+  void NotifyWarningsChanged(const std::set<std::string>& affected_extensions);
 
   // ExtensionRegistryObserver implementation.
   void OnExtensionUnloaded(content::BrowserContext* browser_context,