[Extensions] Move remaining notifications out of ExtensionSettingsHandler

extensions/browser/warning_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_WARNING_SERVICE_H_
 #define EXTENSIONS_BROWSER_WARNING_SERVICE_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 20 matching lines @@
 // Manages a set of warnings caused by extensions. These warnings (e.g.
 // conflicting modifications of network requests by extensions, slow extensions,
 // etc.) trigger a warning badge in the UI and and provide means to resolve
 // them. This class must be used on the UI thread only.
 class WarningService : public KeyedService,
                        public ExtensionRegistryObserver,
                        public base::NonThreadSafe {
  public:
   class Observer {
    public:
-    virtual void ExtensionWarningsChanged() = 0;
+    virtual void ExtensionWarningsChanged(
+        const std::set<std::string>& affected_extensions) = 0;

[not at google - send to devlin, 2015/05/19 20:35:05]

I'd like to pass around an ExtensionSet, but I see we're pigeonholed here by the
way the warning service is factored. Not worth the changes required to use real
Extensions rather than their IDs. In lieu of that, we can pass around an
ExtensionIdSet?

[Devlin, 2015/05/19 22:01:08]

Sure, why not.

   };
 
   // |browser_context| may be NULL for testing. In this case, be sure to not
   // insert any warnings.
   explicit WarningService(content::BrowserContext* browser_context);
   ~WarningService() override;
 
   // Get the instance of the WarningService for |browser_context|.
   // Redirected in incognito.
   static WarningService* Get(content::BrowserContext* browser_context);
@@ skipping 16 matching lines @@
   void AddWarnings(const WarningSet& warnings);
 
   // Notifies the WarningService of browser_context |browser_context_id| that
   // new |warnings| occurred and triggers a warning badge.
   static void NotifyWarningsOnUI(void* profile_id, const WarningSet& warnings);
 
   void AddObserver(Observer* observer);
   void RemoveObserver(Observer* observer);
 
  private:
-  void NotifyWarningsChanged();
+  void NotifyWarningsChanged(const std::set<std::string>& affected_extensions);
 
   // ExtensionRegistryObserver implementation.
   void OnExtensionUnloaded(content::BrowserContext* browser_context,
                            const Extension* extension,
                            UnloadedExtensionInfo::Reason reason) override;
 
   // Currently existing warnings.
   WarningSet warnings_;
 
   content::BrowserContext* const browser_context_;
 
   // Listen to extension unloaded notifications.
   ScopedObserver<ExtensionRegistry, ExtensionRegistryObserver>
       extension_registry_observer_;
 
   ObserverList<Observer> observer_list_;
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_WARNING_SERVICE_H_