Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: chrome/browser/resources/extensions/extensions.js

Issue 1146693004: [Extensions] Move remaining notifications out of ExtensionSettingsHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/extensions.js
diff --git a/chrome/browser/resources/extensions/extensions.js b/chrome/browser/resources/extensions/extensions.js
index 5e1812dbf250d7fd4b08858539e1d2b5230dca2b..3dc9635ade7674f3a669872e8ec044e4ddb3576b 100644
--- a/chrome/browser/resources/extensions/extensions.js
+++ b/chrome/browser/resources/extensions/extensions.js
@@ -148,10 +148,12 @@ cr.define('extensions', function() {
var wrapper = $('extension-list-wrapper');
wrapper.insertBefore(extensionList, wrapper.firstChild);
- this.update_();
- // TODO(devlin): Remove this once all notifications are moved to events on
- // the developerPrivate api.
- chrome.send('extensionSettingsRegister');
+ // Get the initial profile state, and register to be notified of any
+ // future changes.
+ chrome.developerPrivate.getProfileConfiguration(
+ this.update_.bind(this));
+ chrome.developerPrivate.onProfileStateChanged.addListener(
+ this.update_.bind(this));
var extensionLoader = extensions.ExtensionLoader.getInstance();
@@ -240,23 +242,14 @@ cr.define('extensions', function() {
},
/**
- * Updates the extensions page to the latest profile and extensions
- * configuration.
- * @private
- */
- update_: function() {
- chrome.developerPrivate.getProfileConfiguration(
- this.returnProfileConfiguration_.bind(this));
- },
-
- /**
* [Re]-Populates the page with data representing the current state of
* installed extensions.
* @param {ProfileInfo} profileInfo
* @private
*/
- returnProfileConfiguration_: function(profileInfo) {
+ update_: function(profileInfo) {
webuiResponded = true;
+
/** @const */
var supervised = profileInfo.isSupervised;
@@ -367,14 +360,6 @@ cr.define('extensions', function() {
};
/**
- * Called by the WebUI when something has changed and the extensions UI needs
- * to be updated.
- */
- ExtensionSettings.onExtensionsChanged = function() {
- ExtensionSettings.getInstance().update_();
- };
-
- /**
* Returns the current overlay or null if one does not exist.
* @return {Element} The overlay element.
*/

Powered by Google App Engine
This is Rietveld 408576698