Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1146633002: Update target of texStorage2D for ES 3 (Closed)

Created:
5 years, 7 months ago by qiankun
Modified:
5 years, 7 months ago
Reviewers:
Zhenyao Mo, bajones, piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update target of texStorage2D for ES 3 Target of texStorage2D should be one of GL_TEXTURE_2D, or GL_TEXTURE_CUBE_MAP. BUG=429053 Committed: https://crrev.com/52c66335924b88b26a6ae88ac9f9b8fed5c97141 Cr-Commit-Position: refs/heads/master@{#330694}

Patch Set 1 #

Patch Set 2 : update gl_tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/tests/gl_texture_storage_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
qiankun
PTAL.
5 years, 7 months ago (2015-05-18 09:52:31 UTC) #2
Zhenyao Mo
LGTM
5 years, 7 months ago (2015-05-18 17:21:45 UTC) #3
piman
lgtm
5 years, 7 months ago (2015-05-18 19:45:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146633002/1
5 years, 7 months ago (2015-05-19 01:28:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/60425)
5 years, 7 months ago (2015-05-19 03:35:39 UTC) #8
qiankun
On 2015/05/19 03:35:39, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 7 months ago (2015-05-19 06:59:25 UTC) #9
Zhenyao Mo
On 2015/05/19 06:59:25, qiankun wrote: > On 2015/05/19 03:35:39, I haz the power (commit-bot) wrote: ...
5 years, 7 months ago (2015-05-19 23:33:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146633002/20001
5 years, 7 months ago (2015-05-20 01:32:26 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-20 03:52:12 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 03:53:03 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/52c66335924b88b26a6ae88ac9f9b8fed5c97141
Cr-Commit-Position: refs/heads/master@{#330694}

Powered by Google App Engine
This is Rietveld 408576698