Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Unified Diff: chrome/browser/ui/browser_instant_controller.cc

Issue 11466007: Add new IPC for searchbox to pipe SearchBox NavigateContentWindow calls to the browser. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: No longer commit on SearchBoxNavigate IPC. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_instant_controller.cc
diff --git a/chrome/browser/ui/browser_instant_controller.cc b/chrome/browser/ui/browser_instant_controller.cc
index 15ec0efa678a1b45dad23dd1d29a556d43671567..86d234ea97b112136db8f5c2d3eafae7ac13ba3c 100644
--- a/chrome/browser/ui/browser_instant_controller.cc
+++ b/chrome/browser/ui/browser_instant_controller.cc
@@ -161,6 +161,15 @@ void BrowserInstantController::UpdateThemeInfoForPreview() {
OnThemeChanged(NULL);
}
+void BrowserInstantController::OpenURLInCurrentTab(const GURL& url) {
+ browser_->OpenURL(content::OpenURLParams(
+ url,
+ content::Referrer(),
+ CURRENT_TAB,
+ content::PAGE_TRANSITION_TYPED,
sky 2012/12/12 00:09:21 Why is this typed, and should the referrer be set?
Shishir 2012/12/12 00:48:28 We talked about this and said we dont want to set
sky 2012/12/12 04:11:19 Omnibox also uses PAGE_TRANSITION_GENERATED. Which
samarth 2012/12/12 16:32:27 The searchbox code has access to InstantAutocomple
Shishir 2012/12/12 20:04:47 Done.
Shishir 2012/12/12 20:04:47 Done.
+ false));
+}
+
void BrowserInstantController::ResetInstant() {
instant_.SetInstantEnabled(IsInstantEnabled(browser_->profile()));
}

Powered by Google App Engine
This is Rietveld 408576698