Add new IPC for searchbox to pipe SearchBox NavigateContentWindow calls to the browser.

chrome/browser/ui/browser_instant_controller.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_instant_controller.h"
 
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/themes/theme_service.h"
@@ skipping 143 matching lines @@
 void BrowserInstantController::UpdateThemeInfoForPreview() {
   // Update theme background info and theme area height.
   // Initialize |theme_info| if necessary.
   // |OnThemeChanged| also updates theme area height if necessary.
   if (!initialized_theme_info_)
     OnThemeChanged(ThemeServiceFactory::GetForProfile(browser_->profile()));
   else
     OnThemeChanged(NULL);
 }
 
+void BrowserInstantController::OpenURLInCurrentTab(const GURL& url) {
+  browser_->OpenURL(content::OpenURLParams(
+      url,
+      content::Referrer(),
+      CURRENT_TAB,
+      content::PAGE_TRANSITION_TYPED,

[sky, 2012/12/12 00:09:21]

Why is this typed, and should the referrer be set?

[Shishir, 2012/12/12 00:48:28]

We talked about this and said we dont want to set referers here since the
navigation happened due to a click on the area that is equivalent of the omnibox
popup .

As for the typed page transition type - because it was the default for
AutcompleteMatch. Do you think any other one fits better here?

[sky, 2012/12/12 04:11:19]

Omnibox also uses PAGE_TRANSITION_GENERATED. Which one it uses depends upon the
entry. Maybe the page needs to pass up some context when invoking this.

[samarth, 2012/12/12 16:32:27]

The searchbox code has access to InstantAutocompleteResult, so it could
determine the appropriate transition type and pass it through.

[Shishir, 2012/12/12 20:04:47]

Done.

[Shishir, 2012/12/12 20:04:47]

Done.

+      false));
+}
+
 void BrowserInstantController::ResetInstant() {
   instant_.SetInstantEnabled(IsInstantEnabled(browser_->profile()));
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // BrowserInstantController, search::SearchModelObserver implementation:
 
 void BrowserInstantController::ModeChanged(const search::Mode& old_mode,
                                            const search::Mode& new_mode) {
   // If mode is now |NTP|, send theme-related information to instant.
@@ skipping 104 matching lines @@
   // part of the image overlay should draw, 'cos the origin is top-left.
   if (!browser_->search_model()->mode().is_ntp() ||
       theme_info_.theme_id.empty() ||
       theme_info_.image_vertical_alignment == THEME_BKGRND_IMAGE_ALIGN_TOP) {
     return;
   }
   instant_.ThemeAreaHeightChanged(theme_area_height_);
 }
 
 }  // namespace chrome