sync/tools/sync_listen_notifications.cc - Issue 1146533005: [Sync] InvalidationService shouldn't CHECK when registering ObjectId for more than one handler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/tools/sync_listen_notifications.cc

Issue 1146533005: [Sync] InvalidationService shouldn't CHECK when registering ObjectId for more than one handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments from Bartosz. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/tools/sync_listen_notifications.cc

diff --git a/sync/tools/sync_listen_notifications.cc b/sync/tools/sync_listen_notifications.cc

index 13468a4cbd968abf839e82cf86b932b1fa5e40cc..c6cc11f10c8d408039dd48b97673e0d8c4e16ba6 100644

--- a/sync/tools/sync_listen_notifications.cc

+++ b/sync/tools/sync_listen_notifications.cc

@@ -201,8 +201,8 @@ int SyncListenNotificationsMain(int argc, char* argv[]) {

// Listen for notifications for all known types.

invalidator->RegisterHandler(&notification_printer);

- invalidator->UpdateRegisteredIds(

- &notification_printer, ModelTypeSetToObjectIdSet(ModelTypeSet::All()));

+ CHECK(invalidator->UpdateRegisteredIds(

+ &notification_printer, ModelTypeSetToObjectIdSet(ModelTypeSet::All())));

ui_loop.Run();

« no previous file with comments | « sync/tools/sync_client.cc ('k') | no next file » | no next file with comments »