Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: sync/tools/sync_listen_notifications.cc

Issue 1146533005: [Sync] InvalidationService shouldn't CHECK when registering ObjectId for more than one handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments from Bartosz. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sync/tools/sync_client.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <cstddef> 5 #include <cstddef>
6 #include <cstdio> 6 #include <cstdio>
7 #include <string> 7 #include <string>
8 8
9 #include "base/at_exit.h" 9 #include "base/at_exit.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 &null_invalidation_state_tracker, 194 &null_invalidation_state_tracker,
195 kClientInfo, 195 kClientInfo,
196 notifier_options.request_context_getter)); 196 notifier_options.request_context_getter));
197 197
198 NotificationPrinter notification_printer; 198 NotificationPrinter notification_printer;
199 199
200 invalidator->UpdateCredentials(email, token); 200 invalidator->UpdateCredentials(email, token);
201 201
202 // Listen for notifications for all known types. 202 // Listen for notifications for all known types.
203 invalidator->RegisterHandler(&notification_printer); 203 invalidator->RegisterHandler(&notification_printer);
204 invalidator->UpdateRegisteredIds( 204 CHECK(invalidator->UpdateRegisteredIds(
205 &notification_printer, ModelTypeSetToObjectIdSet(ModelTypeSet::All())); 205 &notification_printer, ModelTypeSetToObjectIdSet(ModelTypeSet::All())));
206 206
207 ui_loop.Run(); 207 ui_loop.Run();
208 208
209 invalidator->UnregisterHandler(&notification_printer); 209 invalidator->UnregisterHandler(&notification_printer);
210 io_thread.Stop(); 210 io_thread.Stop();
211 return 0; 211 return 0;
212 } 212 }
213 213
214 } // namespace 214 } // namespace
215 } // namespace syncer 215 } // namespace syncer
216 216
217 int main(int argc, char* argv[]) { 217 int main(int argc, char* argv[]) {
218 return syncer::SyncListenNotificationsMain(argc, argv); 218 return syncer::SyncListenNotificationsMain(argc, argv);
219 } 219 }
OLDNEW
« no previous file with comments | « sync/tools/sync_client.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698