Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 1146493003: Remove the deprecation messages for hspace/vspace attributes on table (Closed)

Created:
5 years, 7 months ago by philipj_slow
Modified:
5 years, 7 months ago
Reviewers:
pdr.
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Remove the deprecation messages for hspace/vspace attributes on table The functionality itself was removed in time for M42: https://codereview.chromium.org/690993003 Three milestones (M42-M44) of warnings after removal is enough. BUG=277080 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195601

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M LayoutTests/platform/android/tables/mozilla/bugs/bug1261-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug1261-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac/tables/mozilla/bugs/bug1261-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/platform/win-xp/tables/mozilla/bugs/bug1261-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/tables/mozilla/bugs/bug1261-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/html/HTMLTableElement.cpp View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
philipj_slow
PTAL
5 years, 7 months ago (2015-05-17 21:53:48 UTC) #2
pdr.
LGTM
5 years, 7 months ago (2015-05-19 20:24:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146493003/1
5 years, 7 months ago (2015-05-19 21:33:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/63127)
5 years, 7 months ago (2015-05-20 03:03:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146493003/1
5 years, 7 months ago (2015-05-20 07:41:26 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 08:40:49 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195601

Powered by Google App Engine
This is Rietveld 408576698