Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Unified Diff: Source/core/dom/Attr.idl

Issue 1146393003: Make Attr.value/nodeValue/textContent not nullable (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add [TreatNullAs=EmptyString] to Attr.nodeValue/textContent Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/dom/coreDOM-element-attribute-js-null-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Attr.idl
diff --git a/Source/core/dom/Attr.idl b/Source/core/dom/Attr.idl
index 7aafbbca683b8b211eb5501bcebfcd2a0824aedc..d1d6d523bebaaa11160f4e15ded2489bfb2aac84 100644
--- a/Source/core/dom/Attr.idl
+++ b/Source/core/dom/Attr.idl
@@ -26,10 +26,9 @@ interface Attr : Node {
readonly attribute DOMString? prefix;
readonly attribute DOMString localName;
readonly attribute DOMString name;
- // FIXME: value/nodeValue/textContent should not be nullable.
- [ImplementedAs=valueForBindings, CustomElementCallbacks] attribute DOMString? value;
- [ImplementedAs=valueForBindings, MeasureAs=AttrNodeValue] attribute DOMString? nodeValue; // legacy alias of .value
- [ImplementedAs=valueForBindings, MeasureAs=AttrTextContent] attribute DOMString? textContent; // legacy alias of .value
+ [ImplementedAs=valueForBindings, CustomElementCallbacks] attribute DOMString value;
+ [TreatNullAs=EmptyString, ImplementedAs=valueForBindings, MeasureAs=AttrNodeValue] attribute DOMString nodeValue; // legacy alias of .value
+ [TreatNullAs=EmptyString, ImplementedAs=valueForBindings, MeasureAs=AttrTextContent] attribute DOMString textContent; // legacy alias of .value
[MeasureAs=AttributeOwnerElement] readonly attribute Element? ownerElement;
« no previous file with comments | « LayoutTests/fast/dom/coreDOM-element-attribute-js-null-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698