Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Side by Side Diff: Source/core/dom/Attr.idl

Issue 1146393003: Make Attr.value/nodeValue/textContent not nullable (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add [TreatNullAs=EmptyString] to Attr.nodeValue/textContent Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/fast/dom/coreDOM-element-attribute-js-null-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com> 3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of 11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13 * Library General Public License for more details. 13 * Library General Public License for more details.
14 * 14 *
15 * You should have received a copy of the GNU Library General Public License 15 * You should have received a copy of the GNU Library General Public License
16 * along with this library; see the file COPYING.LIB. If not, write to 16 * along with this library; see the file COPYING.LIB. If not, write to
17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
18 * Boston, MA 02110-1301, USA. 18 * Boston, MA 02110-1301, USA.
19 */ 19 */
20 20
21 // https://dom.spec.whatwg.org/#interface-attr 21 // https://dom.spec.whatwg.org/#interface-attr
22 22
23 // FIXME: Attr should not inherit from Node. crbug.com/305105 23 // FIXME: Attr should not inherit from Node. crbug.com/305105
24 interface Attr : Node { 24 interface Attr : Node {
25 readonly attribute DOMString? namespaceURI; 25 readonly attribute DOMString? namespaceURI;
26 readonly attribute DOMString? prefix; 26 readonly attribute DOMString? prefix;
27 readonly attribute DOMString localName; 27 readonly attribute DOMString localName;
28 readonly attribute DOMString name; 28 readonly attribute DOMString name;
29 // FIXME: value/nodeValue/textContent should not be nullable. 29 [ImplementedAs=valueForBindings, CustomElementCallbacks] attribute DOMString value;
30 [ImplementedAs=valueForBindings, CustomElementCallbacks] attribute DOMString ? value; 30 [TreatNullAs=EmptyString, ImplementedAs=valueForBindings, MeasureAs=AttrNode Value] attribute DOMString nodeValue; // legacy alias of .value
31 [ImplementedAs=valueForBindings, MeasureAs=AttrNodeValue] attribute DOMStrin g? nodeValue; // legacy alias of .value 31 [TreatNullAs=EmptyString, ImplementedAs=valueForBindings, MeasureAs=AttrText Content] attribute DOMString textContent; // legacy alias of .value
32 [ImplementedAs=valueForBindings, MeasureAs=AttrTextContent] attribute DOMStr ing? textContent; // legacy alias of .value
33 32
34 [MeasureAs=AttributeOwnerElement] readonly attribute Element? ownerElement; 33 [MeasureAs=AttributeOwnerElement] readonly attribute Element? ownerElement;
35 34
36 [MeasureAs=AttributeSpecified] readonly attribute boolean specified; // usel ess; always returns true 35 [MeasureAs=AttributeSpecified] readonly attribute boolean specified; // usel ess; always returns true
37 36
38 // FIXME: Attr should not have any child nodes. crbug.com/305105 37 // FIXME: Attr should not have any child nodes. crbug.com/305105
39 [DeprecateAs=AttrChildAccess] readonly attribute NodeList childNodes; 38 [DeprecateAs=AttrChildAccess] readonly attribute NodeList childNodes;
40 [DeprecateAs=AttrChildAccess] readonly attribute Node firstChild; 39 [DeprecateAs=AttrChildAccess] readonly attribute Node firstChild;
41 [DeprecateAs=AttrChildAccess] readonly attribute Node lastChild; 40 [DeprecateAs=AttrChildAccess] readonly attribute Node lastChild;
42 }; 41 };
OLDNEW
« no previous file with comments | « LayoutTests/fast/dom/coreDOM-element-attribute-js-null-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698