Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Unified Diff: shell/child_process_host_unittest.cc

Issue 1146273002: Make ChildProcessHost::DoLaunch() not touch a random set of things on a different thread. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/child_process_host.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/child_process_host_unittest.cc
diff --git a/shell/child_process_host_unittest.cc b/shell/child_process_host_unittest.cc
index bb1817b5ee7b4472d79157a94dc76389a6a690fb..d4dc4a8f80de8cc9aa88b04f7ca2b331b4274771 100644
--- a/shell/child_process_host_unittest.cc
+++ b/shell/child_process_host_unittest.cc
@@ -25,9 +25,9 @@ class TestChildProcessHost : public ChildProcessHost {
explicit TestChildProcessHost(Context* context) : ChildProcessHost(context) {}
~TestChildProcessHost() override {}
- void DidStart(bool success) override {
- EXPECT_TRUE(success);
- ChildProcessHost::DidStart(success);
+ void DidStart(base::Process child_process) override {
+ EXPECT_TRUE(child_process.IsValid());
+ ChildProcessHost::DidStart(child_process.Pass());
base::MessageLoop::current()->QuitWhenIdle();
}
« no previous file with comments | « shell/child_process_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698