Make ChildProcessHost::DoLaunch() not touch a random set of things on a different thread.

shell/child_process_host_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Note: This file also partly tests child_main.*.
 
 #include "shell/child_process_host.h"
 
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/message_loop/message_loop.h"
 #include "build/build_config.h"
 #include "mojo/common/message_pump_mojo.h"
 #include "mojo/public/c/system/types.h"
 #include "mojo/public/cpp/system/message_pipe.h"
 #include "shell/context.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace shell {
 namespace {
 
 // Subclass just so we can observe |DidStart()|.
 class TestChildProcessHost : public ChildProcessHost {
  public:
   explicit TestChildProcessHost(Context* context) : ChildProcessHost(context) {}
   ~TestChildProcessHost() override {}
 
-  void DidStart(bool success) override {
-    EXPECT_TRUE(success);
-    ChildProcessHost::DidStart(success);
+  void DidStart(base::Process child_process) override {
+    EXPECT_TRUE(child_process.IsValid());
+    ChildProcessHost::DidStart(child_process.Pass());
     base::MessageLoop::current()->QuitWhenIdle();
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(TestChildProcessHost);
 };
 
 #if defined(OS_ANDROID)
 // TODO(qsr): Multiprocess shell tests are not supported on android.
 #define MAYBE_StartJoin DISABLED_StartJoin
@@ skipping 51 matching lines @@
   EXPECT_EQ(MOJO_RESULT_UNKNOWN, result);
   int exit_code = child_process_host.Join();
   VLOG(2) << "Joined child: exit_code = " << exit_code;
   EXPECT_EQ(123, exit_code);
 
   context.Shutdown();
 }
 
 }  // namespace
 }  // namespace shell