Issue 1146273002: Make ChildProcessHost::DoLaunch() not touch a random set of things on a different thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1146273002: Make ChildProcessHost::DoLaunch() not touch a random set of things on a different thread. (Closed)

Created:
5 years, 7 months ago by viettrungluu

Modified:
5 years, 7 months ago

Reviewers:
yzshen1

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make ChildProcessHost::DoLaunch() not touch a random set of things on a different thread. (AFAICT, everything was "safe", except for the race condition noted in OutOfProcessNativeRunner::~OutOfProcessNativeRunner(). That race condition still exists, but at least now it's more predictable and not as bad, and it should now be possible to fix Join().) R=yzshen@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d5e2131d2dfde88dc4740eeec458941a7984232a

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -23 lines)			Patch
M	shell/child_process_host.h	View	3 chunks	+7 lines, -4 lines	0 comments	Download
M	shell/child_process_host.cc	View	6 chunks	+30 lines, -16 lines	0 comments	Download
M	shell/child_process_host_unittest.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

5 years, 7 months ago (2015-05-20 23:35:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d5e2131d2dfde88dc4740eeec458941a7984232a (presubmit successful).

Expand Messages | Collapse Messages