Cleaning up CRWBrowsingDataMode

Cleaning up CRWBrowsingDataMode

2 notable changes
1) Moved this inside an NS_ENUM inside the web namespace for
consistency with BrowsingDataTypes

2) Changed SYNCHRONIZING to CHANGING for 2 reasons
- It better reflects the actual intent of this enum value.
SYNCHRONIZING does not mean much in the context of the
CRWBrowsingDataStore since it's unclear
which object it's trying to synchronize with.
- To avoid confusion with |BrowsingDataParition::IsSynchronized|

BUG=480654
Committed: https://crrev.com/e5e2170f1386a4e6f737f54bf04c7e81d2d24c24
Cr-Commit-Position: refs/heads/master@{#333135}

[shreyasv1, 2015-06-03 22:39:58]

shreyasv@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2015-06-04 15:42:59]

lgtm, please update CL description to fit 76 characters.

https://codereview.chromium.org/1146223012/diff/1/ios/web/crw_browsing_data_s...
File ios/web/crw_browsing_data_store_unittest.mm (right):

https://codereview.chromium.org/1146223012/diff/1/ios/web/crw_browsing_data_s...
ios/web/crw_browsing_data_store_unittest.mm:161: web::BrowsingDataStoreMode mode
= [browsing_data_store_ mode];
Drop web:: this code is already in web namespace.

https://codereview.chromium.org/1146223012/diff/1/ios/web/crw_browsing_data_s...
ios/web/crw_browsing_data_store_unittest.mm:178: web::BrowsingDataStoreMode mode
= [browsing_data_store_ mode];
ditto

[shreyasv1, 2015-06-05 21:05:51]

https://codereview.chromium.org/1146223012/diff/1/ios/web/crw_browsing_data_s...
File ios/web/crw_browsing_data_store_unittest.mm (right):

https://codereview.chromium.org/1146223012/diff/1/ios/web/crw_browsing_data_s...
ios/web/crw_browsing_data_store_unittest.mm:161: web::BrowsingDataStoreMode mode
= [browsing_data_store_ mode];
On 2015/06/04 15:42:59, eugenebut wrote:
> Drop web:: this code is already in web namespace.

Done.

https://codereview.chromium.org/1146223012/diff/1/ios/web/crw_browsing_data_s...
ios/web/crw_browsing_data_store_unittest.mm:178: web::BrowsingDataStoreMode mode
= [browsing_data_store_ mode];
On 2015/06/04 15:42:58, eugenebut wrote:
> ditto

Done.

[shreyasv1, 2015-06-05 21:05:55]

The CQ bit was checked by shreyasv@chromium.org

[shreyasv1, 2015-06-05 21:05:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/1146223012/#ps20001
(title: "y")

[commit-bot: I haz the power, 2015-06-05 21:06:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1146223012/20001

[commit-bot: I haz the power, 2015-06-05 21:19:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-05 21:21:25]

Patchset 2 (id:??) landed as
https://crrev.com/e5e2170f1386a4e6f737f54bf04c7e81d2d24c24
Cr-Commit-Position: refs/heads/master@{#333135}