Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: ios/web/public/crw_browsing_data_store.h

Issue 1146223012: Cleaning up CRWBrowsingDataMode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: y Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/crw_browsing_data_store_unittest.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/public/crw_browsing_data_store.h
diff --git a/ios/web/public/crw_browsing_data_store.h b/ios/web/public/crw_browsing_data_store.h
index 20eae8160ba0c0ada015bc3958bd282448525650..adfccef978bcba5353426a2494059ef955430be4 100644
--- a/ios/web/public/crw_browsing_data_store.h
+++ b/ios/web/public/crw_browsing_data_store.h
@@ -22,21 +22,21 @@ typedef NS_OPTIONS(NSUInteger, BrowsingDataTypes) {
BROWSING_DATA_TYPE_ALL = BROWSING_DATA_TYPE_COOKIES,
};
-} // namespace web
-
-// Represents the modes that a CRWBrowsingDataStore is currently at.
-enum CRWBrowsingDataStoreMode {
+// Represents the modes that a CRWBrowsingDataStore can be in.
+typedef NS_ENUM(NSUInteger, BrowsingDataStoreMode) {
// Web views (associated transitively through the BrowseState) are
// flushing/reading their data from disk.
- ACTIVE,
+ ACTIVE = 1,
// The CRWBrowsingDataStore's mode is in the process of becoming either ACTIVE
// or INACTIVE.
- SYNCHRONIZING,
+ CHANGING,
// Browsing data is stored in a path unique to the BrowserState and is
// currently not being read or written to by web views.
- INACTIVE
+ INACTIVE,
};
+} // namespace web
+
// A CRWBrowsingDataStore represents various types of data that a web view
// (UIWebView and WKWebView) uses.
// All methods must be called on the UI thread.
@@ -52,7 +52,7 @@ enum CRWBrowsingDataStoreMode {
@property(nonatomic, weak) id<CRWBrowsingDataStoreDelegate> delegate;
// The mode that the CRWBrowsingDataStore is in. KVO compliant.
-@property(nonatomic, assign, readonly) CRWBrowsingDataStoreMode mode;
+@property(nonatomic, assign, readonly) web::BrowsingDataStoreMode mode;
// TODO(shreyasv): Verify the preconditions for the following 3 methods when
// web::WebViewCounter class is implemented. crbug.com/480507
« no previous file with comments | « ios/web/crw_browsing_data_store_unittest.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698