Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1146183005: The span of a table-column or table-column-group should never be 0. (Closed)

Created:
5 years, 6 months ago by mstensho (USE GERRIT)
Modified:
5 years, 6 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

The span of a table-column or table-column-group should never be 0. We used to set span to 0 if the element type wasn't COL/COLGROUP and computed style had been set and display type was table-column-group. This seems to stem from a merge from some LABYRINTH_KDE_3_MERGE branch back in March 2002. Not sure if it made sense back then, but it certainly doesn't now. BUG=493352 R=jchaffraix@chromium.org,leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196166

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
A LayoutTests/fast/table/crash-output-element-as-column-group.html View 1 chunk +8 lines, -0 lines 0 comments Download
A LayoutTests/fast/table/crash-output-element-as-column-group-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutTableCol.cpp View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 6 months ago (2015-05-29 15:46:42 UTC) #1
leviw_travelin_and_unemployed
lgtm https://codereview.chromium.org/1146183005/diff/1/Source/core/layout/LayoutTableCol.cpp File Source/core/layout/LayoutTableCol.cpp (left): https://codereview.chromium.org/1146183005/diff/1/Source/core/layout/LayoutTableCol.cpp#oldcode81 Source/core/layout/LayoutTableCol.cpp:81: m_span = !(style() && style()->display() == TABLE_COLUMN_GROUP); This ...
5 years, 6 months ago (2015-05-29 17:07:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146183005/1
5 years, 6 months ago (2015-05-29 17:07:29 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-05-29 19:59:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196166

Powered by Google App Engine
This is Rietveld 408576698