Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: Source/core/layout/LayoutTableCol.cpp

Issue 1146183005: The span of a table-column or table-column-group should never be 0. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/table/crash-output-element-as-column-group-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/LayoutTableCol.cpp
diff --git a/Source/core/layout/LayoutTableCol.cpp b/Source/core/layout/LayoutTableCol.cpp
index 37c07f4dcdf6b3e376d68f509b2b58927852c371..73cf46dd452d94d3a96f7b9e5add71f4f5957fa1 100644
--- a/Source/core/layout/LayoutTableCol.cpp
+++ b/Source/core/layout/LayoutTableCol.cpp
@@ -78,7 +78,7 @@ void LayoutTableCol::updateFromElement()
HTMLTableColElement& tc = toHTMLTableColElement(*n);
m_span = tc.span();
} else {
- m_span = !(style() && style()->display() == TABLE_COLUMN_GROUP);
leviw_travelin_and_unemployed 2015/05/29 17:07:12 This was just weird to begin with!
+ m_span = 1;
}
if (m_span != oldSpan && style() && parent())
setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidation(LayoutInvalidationReason::AttributeChanged);
« no previous file with comments | « LayoutTests/fast/table/crash-output-element-as-column-group-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698