Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1146133005: Close new child window if its only navigation was opening a Native app. (Closed)

Created:
5 years, 6 months ago by Eugene But (OOO till 7-30)
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Close new child window if its only navigation was opening a Native app. There is no reason to keep a bank Tab in case if newly opened window launched an external app. This behavior is similar to launching native apps. BUG=496419 Committed: https://crrev.com/af891d356a02e245e7be1aa7ac6c881cf92433a3 Cr-Commit-Position: refs/heads/master@{#333120}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Eugene But (OOO till 7-30)
5 years, 6 months ago (2015-06-04 01:35:11 UTC) #2
Jackie Quinn
lgtm!
5 years, 6 months ago (2015-06-04 02:15:14 UTC) #3
stuartmorgan
lgtm
5 years, 6 months ago (2015-06-05 15:18:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146133005/1
5 years, 6 months ago (2015-06-05 20:30:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 20:43:29 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 20:44:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af891d356a02e245e7be1aa7ac6c881cf92433a3
Cr-Commit-Position: refs/heads/master@{#333120}

Powered by Google App Engine
This is Rietveld 408576698