ios/web/web_state/ui/crw_web_controller.mm - Issue 1146133005: Close new child window if its only navigation was opening a Native app.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/crw_web_controller.mm

Issue 1146133005: Close new child window if its only navigation was opening a Native app. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/web/web_state/ui/crw_web_controller.mm

diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm

index 2cc2e795d181e20c007abed5e5e52a90ad728bfc..c566bf0a7f59235fb7c81e01fb4790880a74323b 100644

--- a/ios/web/web_state/ui/crw_web_controller.mm

+++ b/ios/web/web_state/ui/crw_web_controller.mm

@@ -2741,7 +2741,8 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;

// Record the URL so that errors reported following the 'NO' reply can be

// safely ignored.

[_openedApplicationURL addObject:request.URL];

- return NO;

+ if ([self cancellable])

+ [_delegate webPageOrderedClose];

}

return NO;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »