Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 1145973011: mojo: Fix Blink's shutdown sequence in AxProviderImplTest (Closed)

Created:
5 years, 6 months ago by Sami
Modified:
5 years, 6 months ago
CC:
chromium-reviews, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojo: Fix Blink's shutdown sequence in AxProviderImplTest This patch ensures the sequence used to tear down Blink in AxProviderImplTest matches the real implementation in RenderThreadImpl. Specifically, we need to shut down the scheduler before terminating Blink, because otherwise the scheduler might keep pointers to tasks that live on the Blink heap and access freed memory in its destructor. We also add an assertion to the renderer scheduler that it is shut down explicitly. Note that Blink cannot shut down the scheduler internally because of crbug.com/467369. We expect that this depedency can be cleaned up once the message loop is better integrated with the scheduler (crbug.com/465354) and when the Blink repository has been merged into Chromium. BUG=463143 Committed: https://crrev.com/23e04e72e8121a372fcbaf779fde9faae2bc772f Cr-Commit-Position: refs/heads/master@{#332221}

Patch Set 1 #

Patch Set 2 : Add missing shutdown call to html_viewer::Setup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M components/html_viewer/ax_provider_impl_unittest.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M components/html_viewer/html_viewer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/setup.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Sami
5 years, 6 months ago (2015-06-01 11:24:30 UTC) #2
alex clarke (OOO till 29th)
LGTM for scheduler
5 years, 6 months ago (2015-06-01 11:38:54 UTC) #3
rmcilroy
LGTM for scheduler
5 years, 6 months ago (2015-06-01 11:51:58 UTC) #4
sky
LGTM
5 years, 6 months ago (2015-06-01 15:17:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145973011/1
5 years, 6 months ago (2015-06-01 15:21:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/94066)
5 years, 6 months ago (2015-06-01 16:21:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145973011/20001
5 years, 6 months ago (2015-06-01 16:41:15 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-01 18:16:56 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 18:18:49 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/23e04e72e8121a372fcbaf779fde9faae2bc772f
Cr-Commit-Position: refs/heads/master@{#332221}

Powered by Google App Engine
This is Rietveld 408576698