Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: components/html_viewer/ax_provider_impl_unittest.cc

Issue 1145973011: mojo: Fix Blink's shutdown sequence in AxProviderImplTest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add missing shutdown call to html_viewer::Setup Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/html_viewer/html_viewer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/html_viewer/ax_provider_impl_unittest.cc
diff --git a/components/html_viewer/ax_provider_impl_unittest.cc b/components/html_viewer/ax_provider_impl_unittest.cc
index 7508f8a7b6d27d018ed977ec79d06091f98a492d..bfbd9a7e44d0bf6b556643408a6bad8e06ed95e3 100644
--- a/components/html_viewer/ax_provider_impl_unittest.cc
+++ b/components/html_viewer/ax_provider_impl_unittest.cc
@@ -47,7 +47,8 @@ class TestWebViewClient : public WebViewClient {
class AxProviderImplTest : public testing::Test {
public:
AxProviderImplTest()
- : renderer_scheduler_(scheduler::RendererScheduler::Create()) {
+ : message_loop_(new base::MessageLoopForUI()),
+ renderer_scheduler_(scheduler::RendererScheduler::Create()) {
#if defined(V8_USE_EXTERNAL_STARTUP_DATA)
gin::V8Initializer::LoadV8Snapshot();
#endif
@@ -55,10 +56,14 @@ class AxProviderImplTest : public testing::Test {
new html_viewer::BlinkPlatformImpl(nullptr, renderer_scheduler_.get()));
}
- ~AxProviderImplTest() override { blink::shutdown(); }
+ ~AxProviderImplTest() override {
+ renderer_scheduler_->Shutdown();
+ message_loop_.reset();
+ blink::shutdown();
+ }
private:
- base::MessageLoopForUI message_loop;
+ scoped_ptr<base::MessageLoopForUI> message_loop_;
scoped_ptr<scheduler::RendererScheduler> renderer_scheduler_;
};
« no previous file with comments | « no previous file | components/html_viewer/html_viewer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698