Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1145973004: [arm] Fix detection of architecture versions. (Closed)

Created:
5 years, 6 months ago by jbramley
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Fix detection of architecture versions. Use __ARM_ARCH_6ZK__ instead of __ARM_ARCH_6KZ__. The architecture is technically called ARMv6KZ, but GCC has always called it 6ZK. Clang defines __ARM_ARCH_6K__ for this target, and is unaffected. BUG=v8:3978 LOG=N Committed: https://crrev.com/84b9afe46695043d9d028a0a328f59159a10cbef Cr-Commit-Position: refs/heads/master@{#28709}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/base/atomicops_internals_arm_gcc.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbramley
5 years, 6 months ago (2015-05-29 16:00:00 UTC) #2
Benedikt Meurer
lgtm
5 years, 6 months ago (2015-06-01 03:58:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145973004/1
5 years, 6 months ago (2015-06-01 03:58:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-01 04:26:32 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 04:26:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84b9afe46695043d9d028a0a328f59159a10cbef
Cr-Commit-Position: refs/heads/master@{#28709}

Powered by Google App Engine
This is Rietveld 408576698