Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4306)

Unified Diff: chrome/browser/download/notification/download_notification_item.cc

Issue 1145953002: [Download Notification] change notification type from SIMPLE to BASE_FORMAT (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/notification/download_notification_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/notification/download_notification_item.cc
diff --git a/chrome/browser/download/notification/download_notification_item.cc b/chrome/browser/download/notification/download_notification_item.cc
index 78a7ecf444b82275d0f651c655fcfed9d6e022fc..10442f7aaef834331a026b9f89c4f47304b6bc0d 100644
--- a/chrome/browser/download/notification/download_notification_item.cc
+++ b/chrome/browser/download/notification/download_notification_item.cc
@@ -200,7 +200,7 @@ void DownloadNotificationItem::UpdateNotificationData(
}
if (item_->IsDangerous()) {
- notification_->set_type(message_center::NOTIFICATION_TYPE_SIMPLE);
+ notification_->set_type(message_center::NOTIFICATION_TYPE_BASE_FORMAT);
notification_->set_title(GetTitle());
notification_->set_message(GetWarningText());
@@ -299,8 +299,8 @@ void DownloadNotificationItem::UpdateNotificationData(
(item_->GetState() == content::DownloadItem::INTERRUPTED &&
previous_download_state_ != content::DownloadItem::INTERRUPTED)) {
CloseNotificationByNonUser();
- // Changes the type from PROGRESS to SIMPLE.
- notification_->set_type(message_center::NOTIFICATION_TYPE_SIMPLE);
+ // Changes the type from PROGRESS to BASE_FORMAT.
+ notification_->set_type(message_center::NOTIFICATION_TYPE_BASE_FORMAT);
notification_ui_manager()->Add(*notification_, profile_);
}
} else {
« no previous file with comments | « chrome/browser/download/notification/download_notification_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698